Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added a faster and more accurate algorithm for mesh_boundary_masker #96

Merged
merged 1 commit into from
Dec 19, 2024

Conversation

hsalehipour
Copy link
Collaborator

Contributing Guidelines

Description

A new algorithm is used for determining masking mesh boundaries tht is more accurate and faster. It relies on wp. mesh_query_aabb rather (that resembles the voxelized domain) rather than wp.mesh_query_point_no_sign that queries awith some spherical distance aroudn that point (not resembling the voxelized domain). Also in the new method the voxels intersecting with the mesh are marked with an id for solver to skip computations. This will help with the overal stability of the solver at high Re. Other changes are minor and mostly are result of doing ruff format .

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

How Has This Been Tested?

  • All pytest tests pass

Linting and Code Formatting

Make sure the code follows the project's linting and formatting standards. This project uses Ruff for linting.

To run Ruff, execute the following command from the root of the repository:

ruff check .
  • Ruff passes

@hsalehipour
Copy link
Collaborator Author

I have also removed the mesh_distance_boundary_masker for now until later that we can use it properly.

@mehdiataei
Copy link
Contributor

Looks good thanks.

@mehdiataei mehdiataei merged commit c48e0ec into Autodesk:main Dec 19, 2024
10 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Dec 19, 2024
@hsalehipour hsalehipour deleted the new_mesh_masker branch December 19, 2024 20:33
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants