Added a faster and more accurate algorithm for mesh_boundary_masker #96
+38
−209
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributing Guidelines
Description
A new algorithm is used for determining masking mesh boundaries tht is more accurate and faster. It relies on
wp. mesh_query_aabb
rather (that resembles the voxelized domain) rather thanwp.mesh_query_point_no_sign
that queries awith some spherical distance aroudn that point (not resembling the voxelized domain). Also in the new method the voxels intersecting with the mesh are marked with an id for solver to skip computations. This will help with the overal stability of the solver at high Re. Other changes are minor and mostly are result of doingruff format .
Type of change
How Has This Been Tested?
Linting and Code Formatting
Make sure the code follows the project's linting and formatting standards. This project uses Ruff for linting.
To run Ruff, execute the following command from the root of the repository:
ruff check .