Added abstraction layer for boundary condition application and stepper initialization, and the capability to add profiles to boundary conditions #86

mehdiataei · 2024-10-31T16:18:43Z

Contributing Guidelines

I have read and understood the CONTRIBUTING.md guidelines

Description

Added abstraction layer for boundary condition efficient encoding/decoding of auxiliary data
Added the capability to add profiles to boundary conditions
Allows mesh boundary masker to be called in JAX as well.
Added abstraction layer to initialize fields and BCs inside stepper (Optionally called)
Fixes Non-uniform boundary velocity profile #74

Type of change

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to not work as expected)
Documentation update

How Has This Been Tested?

All pytest tests pass

Linting and Code Formatting

Make sure the code follows the project's linting and formatting standards. This project uses Ruff for linting.

To run Ruff, execute the following command from the root of the repository:

ruff check .

Ruff passes

hsalehipour

Thanks for the PR. This is very helpful. I have made some comments which I think will improve this work.

examples/cfd/flow_past_sphere_3d.py

examples/cfd/windtunnel_3d.py

xlb/operator/boundary_condition/bc_regularized.py

xlb/operator/boundary_condition/bc_zouhe.py

examples/cfd/windtunnel_3d.py

examples/cfd/flow_past_sphere_3d.py

examples/cfd/lid_driven_cavity_2d.py

xlb/operator/boundary_condition/bc_extrapolation_outflow.py

mehdiataei · 2024-11-04T23:46:08Z

Thanks for the PR. This is very helpful. I have made some comments which I think will improve this work.

Thanks for the comments. I'll take a look.

autodesk-chorus · 2024-11-28T16:40:56Z

Chorus detected one or more security issues with this pull request. See the Checks tab for more details.

As a reminder, please follow the secure code review process as part of the Secure Coding Non-Negotiable requirement.

hsalehipour

Thanks for the improved PR. I have left lots of commetns (major revisions). Please apply the changes and ping me again to review. I am happy to add these changes directly myself if you prefer. Thank you.

examples/cfd/flow_past_sphere_3d.py

examples/cfd/lid_driven_cavity_2d.py

xlb/operator/boundary_condition/bc_zouhe.py

xlb/operator/boundary_condition/bc_regularized.py

xlb/operator/boundary_masker/mesh_boundary_masker.py

hsalehipour

please see all my comments. They are all minor. Let's close this today after these minor changes.

xlb/helper/nse_solver.py

hsalehipour · 2024-12-05T14:58:57Z

xlb/operator/boundary_condition/bc_regularized.py

@@ -222,6 +218,15 @@ def functional_velocity(
            # Find normal vector
            normals = get_normal_vectors(missing_mask)

+            # Find the value of u from the missing directions
+            for l in range(wp.static(_q)):


please remove wp.static inside range. There are two occasions in the file.

hsalehipour · 2024-12-05T15:01:28Z

xlb/operator/boundary_condition/bc_regularized.py

@@ -253,6 +258,13 @@ def functional_pressure(
            # Find normal vector
            normals = get_normal_vectors(missing_mask)

+            # Find the value of rho from the missing directions
+            for q in range(wp.static(_q)):


xlb/operator/boundary_condition/bc_zouhe.py

xlb/operator/boundary_masker/indices_boundary_masker.py

examples/cfd/windtunnel_3d.py

examples/cfd/turbulent_channel_3d.py

hsalehipour

Please just change BGK to KBC in turbulent channel flow and then go ahead and merge.

…r initialization, and the capability to add profiles to boundary conditions

mehdiataei marked this pull request as ready for review October 31, 2024 16:56

mehdiataei requested review from massimim and hsalehipour October 31, 2024 17:34

mehdiataei changed the title ~~Profile inlet~~ Added abstraction layer for boundary condition and the capability to add profiles to boundary conditions Oct 31, 2024

mehdiataei force-pushed the profile_inlet branch 6 times, most recently from f0f81c3 to d07713d Compare November 4, 2024 01:39

hsalehipour requested changes Nov 4, 2024

View reviewed changes

mehdiataei force-pushed the profile_inlet branch from d07713d to 6da9f20 Compare November 28, 2024 16:40

mehdiataei force-pushed the profile_inlet branch from 6da9f20 to 62f9ba0 Compare November 28, 2024 16:42

mehdiataei changed the title ~~Added abstraction layer for boundary condition and the capability to add profiles to boundary conditions~~ Added abstraction layer for boundary condition aux data and implementaiton, and the capability to add profiles to boundary conditions Nov 28, 2024

mehdiataei force-pushed the profile_inlet branch 3 times, most recently from c954e93 to 49cb066 Compare November 28, 2024 22:47

mehdiataei requested review from hsalehipour and removed request for massimim November 28, 2024 22:51

hsalehipour requested changes Nov 29, 2024

View reviewed changes

mehdiataei force-pushed the profile_inlet branch 2 times, most recently from 530e82d to 53f626c Compare November 30, 2024 01:35

mehdiataei force-pushed the profile_inlet branch 4 times, most recently from b8f5ba2 to c7b2237 Compare December 4, 2024 00:10

mehdiataei force-pushed the profile_inlet branch 2 times, most recently from c4db4ab to ce1006c Compare December 5, 2024 08:58

hsalehipour self-requested a review December 5, 2024 14:58

hsalehipour requested changes Dec 5, 2024

View reviewed changes

mehdiataei force-pushed the profile_inlet branch 2 times, most recently from 98a2e19 to 00eebf7 Compare December 5, 2024 20:33

hsalehipour self-requested a review December 5, 2024 21:30

hsalehipour approved these changes Dec 5, 2024

View reviewed changes

Added abstraction layer for boundary condition application and steppe…

877433a

…r initialization, and the capability to add profiles to boundary conditions

mehdiataei force-pushed the profile_inlet branch from 00eebf7 to 877433a Compare December 5, 2024 22:16

mehdiataei merged commit f7bed81 into Autodesk:main Dec 5, 2024
10 checks passed

github-actions bot locked and limited conversation to collaborators Dec 5, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Added abstraction layer for boundary condition application and stepper initialization, and the capability to add profiles to boundary conditions #86

Added abstraction layer for boundary condition application and stepper initialization, and the capability to add profiles to boundary conditions #86

mehdiataei commented Oct 31, 2024 •

edited

Loading

hsalehipour left a comment •

edited

Loading

mehdiataei commented Nov 4, 2024

autodesk-chorus bot commented Nov 28, 2024

hsalehipour left a comment

hsalehipour left a comment

hsalehipour Dec 5, 2024

hsalehipour Dec 5, 2024

hsalehipour left a comment

Added abstraction layer for boundary condition application and stepper initialization, and the capability to add profiles to boundary conditions #86

Added abstraction layer for boundary condition application and stepper initialization, and the capability to add profiles to boundary conditions #86

Conversation

mehdiataei commented Oct 31, 2024 • edited Loading

Contributing Guidelines

Description

Type of change

How Has This Been Tested?

Linting and Code Formatting

hsalehipour left a comment • edited Loading

Choose a reason for hiding this comment

mehdiataei commented Nov 4, 2024

autodesk-chorus bot commented Nov 28, 2024

hsalehipour left a comment

Choose a reason for hiding this comment

hsalehipour left a comment

Choose a reason for hiding this comment

hsalehipour Dec 5, 2024

Choose a reason for hiding this comment

hsalehipour Dec 5, 2024

Choose a reason for hiding this comment

hsalehipour left a comment

Choose a reason for hiding this comment

mehdiataei commented Oct 31, 2024 •

edited

Loading

hsalehipour left a comment •

edited

Loading