Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Staggered grid #24

Merged
merged 21 commits into from
Oct 25, 2022
Merged

Staggered grid #24

merged 21 commits into from
Oct 25, 2022

Conversation

massimim
Copy link
Collaborator

@massimim massimim commented Oct 21, 2022 •
edited
Loading

Adding staggered grid abstraction.

  • Fixing bug in dGrid
  • Adding code for a guided tutorial on staggered grids
  • Unit test for staggered grid with dGrid

Notes:

@massimim massimim self-assigned this Oct 21, 2022
@massimim massimim added the enhancement New feature or request label Oct 21, 2022
@massimim massimim force-pushed the staggered-grid branch 2 times, most recently from a957f73 to d40a44e Compare October 21, 2022 14:41
@massimim massimim requested a review from Ahdhn October 24, 2022 23:53
@massimim massimim removed the request for review from Ahdhn October 25, 2022 00:49
@massimim massimim marked this pull request as draft October 25, 2022 00:49
@massimim massimim force-pushed the staggered-grid branch 2 times, most recently from 47d3398 to e49f5ac Compare October 25, 2022 02:04
@massimim
Copy link
Collaborator Author

Test log on gpu6:

Test project /home/max/Neon/temp/Neon/build
      Start  1: coreUt_chrono
 1/42 Test  #1: coreUt_chrono .....................   Passed   36.01 sec
      Start  2: coreUt_cli
 2/42 Test  #2: coreUt_cli ........................   Passed    0.01 sec
      Start  3: coreUt_digraph
 3/42 Test  #3: coreUt_digraph ....................   Passed    0.01 sec
      Start  4: coreUt_exceptions
 4/42 Test  #4: coreUt_exceptions .................   Passed    0.01 sec
      Start  5: coreUt_io
 5/42 Test  #5: coreUt_io .........................   Passed   36.89 sec
      Start  6: coreUt_logging
 6/42 Test  #6: coreUt_logging ....................   Passed    0.00 sec
      Start  7: coreUt_tools
 7/42 Test  #7: coreUt_tools ......................   Passed    0.00 sec
      Start  8: coreUt_tuple3d
 8/42 Test  #8: coreUt_tuple3d ....................   Passed    0.00 sec
      Start  9: sysUt_devCpu
 9/42 Test  #9: sysUt_devCpu ......................   Passed    0.27 sec
      Start 10: sysUt_devGpu
10/42 Test #10: sysUt_devGpu ......................   Passed    0.42 sec
      Start 11: sysUt_devGpuNvcc
11/42 Test #11: sysUt_devGpuNvcc ..................   Passed    0.44 sec
      Start 12: sysUt_mem
12/42 Test #12: sysUt_mem .........................   Passed    0.44 sec
      Start 13: sysUt_mem3d
13/42 Test #13: sysUt_mem3d .......................   Passed    0.85 sec
      Start 14: sysUt_patterns
14/42 Test #14: sysUt_patterns ....................   Passed    1.18 sec
      Start 15: sysUt_report
15/42 Test #15: sysUt_report ......................   Passed    0.24 sec
      Start 16: setUt_gpuSet
16/42 Test #16: setUt_gpuSet ......................   Passed    1.06 sec
      Start 17: setUt_gpuSetNvcc
17/42 Test #17: setUt_gpuSetNvcc ..................   Passed    0.23 sec
      Start 18: setUt_memMirrorSet
18/42 Test #18: setUt_memMirrorSet ................   Passed    1.01 sec
      Start 19: setUt_patterns
19/42 Test #19: setUt_patterns ....................   Passed    1.12 sec
      Start 20: setUt_multiDeviceObject
20/42 Test #20: setUt_multiDeviceObject ...........   Passed    0.45 sec
      Start 21: setUt_containerGraph
21/42 Test #21: setUt_containerGraph ..............   Passed    3.16 sec
      Start 22: gUt_containers
22/42 Test #22: gUt_containers ....................   Passed    0.54 sec
      Start 23: gUt_containers
23/42 Test #23: gUt_containers ....................   Passed    0.55 sec
      Start 24: gUt_dataView_patterns
24/42 Test #24: gUt_dataView_patterns .............   Passed  407.65 sec
      Start 25: domain-unit-test-map
25/42 Test #25: domain-unit-test-map ..............   Passed    3.62 sec
      Start 26: gUt_patterns_container
26/42 Test #26: gUt_patterns_container ............   Passed  605.36 sec
      Start 27: domainUt_swap
27/42 Test #27: domainUt_swap .....................   Passed    8.20 sec
      Start 28: domain-unit-test-staggered-grid
28/42 Test #28: domain-unit-test-staggered-grid ...   Passed    9.68 sec
      Start 29: gUt_tools
29/42 Test #29: gUt_tools .........................   Passed    0.29 sec
      Start 30: gUt_vtk
30/42 Test #30: gUt_vtk ...........................   Passed    0.54 sec
      Start 31: gUt_bGrid
31/42 Test #31: gUt_bGrid .........................   Passed    0.41 sec
      Start 32: sUt_skeleton
32/42 Test #32: sUt_skeleton ......................   Passed  110.32 sec
      Start 33: sUt_skeletonOnStreams
33/42 Test #33: sUt_skeletonOnStreams .............   Passed   86.72 sec
      Start 34: sUt_userInterface
34/42 Test #34: sUt_userInterface .................   Passed  165.34 sec
      Start 35: sUt_stencil
35/42 Test #35: sUt_stencil .......................   Passed    1.73 sec
      Start 36: solverUt_Poisson
36/42 Test #36: solverUt_Poisson ..................   Passed    0.25 sec
      Start 37: solverPt_Poisson
37/42 Test #37: solverPt_Poisson ..................   Passed    5.03 sec
      Start 38: tutorial-staggered-grid
38/42 Test #38: tutorial-staggered-grid ...........   Passed    0.27 sec
      Start 39: app-fractal
39/42 Test #39: app-fractal .......................   Passed    0.93 sec
      Start 40: app-lbm
40/42 Test #40: app-lbm ...........................   Passed   26.99 sec
      Start 41: app-gameOfLife
41/42 Test #41: app-gameOfLife ....................   Passed   16.75 sec
      Start 42: app-poisson
42/42 Test #42: app-poisson .......................   Passed    4.33 sec

100% tests passed, 0 tests failed out of 42

@massimim massimim requested a review from Ahdhn October 25, 2022 02:41
@massimim massimim marked this pull request as ready for review October 25, 2022 02:41
@Ahdhn
Copy link
Collaborator

Ahdhn commented Oct 25, 2022

On Windows

Test project E:/Github/Neon/temp/Neon/build
      Start  1: coreUt_chrono
 1/42 Test  #1: coreUt_chrono .....................   Passed   36.40 sec
      Start  2: coreUt_cli
 2/42 Test  #2: coreUt_cli ........................   Passed    0.28 sec
      Start  3: coreUt_digraph
 3/42 Test  #3: coreUt_digraph ....................   Passed    0.27 sec
      Start  4: coreUt_exceptions
 4/42 Test  #4: coreUt_exceptions .................   Passed    0.40 sec
      Start  5: coreUt_io
 5/42 Test  #5: coreUt_io .........................   Passed   38.22 sec
      Start  6: coreUt_logging
 6/42 Test  #6: coreUt_logging ....................   Passed    0.47 sec
      Start  7: coreUt_tools
 7/42 Test  #7: coreUt_tools ......................   Passed    0.26 sec
      Start  8: coreUt_tuple3d
 8/42 Test  #8: coreUt_tuple3d ....................   Passed    0.29 sec
      Start  9: sysUt_devCpu
 9/42 Test  #9: sysUt_devCpu ......................   Passed    0.44 sec
      Start 10: sysUt_devGpu
10/42 Test #10: sysUt_devGpu ......................   Passed    0.69 sec
      Start 11: sysUt_devGpuNvcc
11/42 Test #11: sysUt_devGpuNvcc ..................   Passed    0.57 sec
      Start 12: sysUt_mem
12/42 Test #12: sysUt_mem .........................   Passed   37.69 sec
      Start 13: sysUt_mem3d
13/42 Test #13: sysUt_mem3d .......................   Passed    0.94 sec
      Start 14: sysUt_patterns
14/42 Test #14: sysUt_patterns ....................   Passed    2.96 sec
      Start 15: sysUt_report
15/42 Test #15: sysUt_report ......................   Passed    0.46 sec
      Start 16: setUt_gpuSet
16/42 Test #16: setUt_gpuSet ......................   Passed    0.57 sec
      Start 17: setUt_gpuSetNvcc
17/42 Test #17: setUt_gpuSetNvcc ..................   Passed    0.48 sec
      Start 18: setUt_memMirrorSet
18/42 Test #18: setUt_memMirrorSet ................   Passed    0.54 sec
      Start 19: setUt_patterns
19/42 Test #19: setUt_patterns ....................   Passed    2.04 sec
      Start 20: setUt_multiDeviceObject
20/42 Test #20: setUt_multiDeviceObject ...........   Passed    0.63 sec
      Start 21: setUt_containerGraph
21/42 Test #21: setUt_containerGraph ..............   Passed    4.53 sec
      Start 22: gUt_containers
22/42 Test #22: gUt_containers ....................   Passed    2.03 sec
      Start 23: gUt_containers
23/42 Test #23: gUt_containers ....................   Passed    0.32 sec
      Start 24: gUt_dataView_patterns
24/42 Test #24: gUt_dataView_patterns .............   Passed  593.32 sec
      Start 25: domain-unit-test-map
25/42 Test #25: domain-unit-test-map ..............   Passed    4.06 sec
      Start 26: gUt_patterns_container
26/42 Test #26: gUt_patterns_container ............   Passed  853.92 sec
      Start 27: domainUt_swap
27/42 Test #27: domainUt_swap .....................   Passed    9.50 sec
      Start 28: domain-unit-test-staggered-grid
28/42 Test #28: domain-unit-test-staggered-grid ...   Passed    8.28 sec
      Start 29: gUt_tools
29/42 Test #29: gUt_tools .........................   Passed    0.49 sec
      Start 30: gUt_vtk
30/42 Test #30: gUt_vtk ...........................   Passed    0.68 sec
      Start 31: gUt_bGrid
31/42 Test #31: gUt_bGrid .........................   Passed    0.58 sec
      Start 32: sUt_skeleton
32/42 Test #32: sUt_skeleton ......................   Passed  139.61 sec
      Start 33: sUt_skeletonOnStreams
33/42 Test #33: sUt_skeletonOnStreams .............   Passed   74.54 sec
      Start 34: sUt_userInterface
34/42 Test #34: sUt_userInterface .................   Passed  139.36 sec
      Start 35: sUt_stencil
35/42 Test #35: sUt_stencil .......................   Passed    2.39 sec
      Start 36: solverUt_Poisson
36/42 Test #36: solverUt_Poisson ..................   Passed    0.77 sec
      Start 37: solverPt_Poisson
37/42 Test #37: solverPt_Poisson ..................   Passed    6.40 sec
      Start 38: tutorial-staggered-grid
38/42 Test #38: tutorial-staggered-grid ...........   Passed    0.48 sec
      Start 39: app-fractal
39/42 Test #39: app-fractal .......................   Passed    0.87 sec
      Start 40: app-lbm
40/42 Test #40: app-lbm ...........................   Passed   36.85 sec
      Start 41: app-gameOfLife
41/42 Test #41: app-gameOfLife ....................   Passed   22.13 sec
      Start 42: app-poisson
42/42 Test #42: app-poisson .......................   Passed    5.32 sec

100% tests passed, 0 tests failed out of 42

@massimim massimim merged commit e033b98 into develop Oct 25, 2022
@massimim massimim deleted the staggered-grid branch October 25, 2022 15:40
@github-actions github-actions bot locked and limited conversation to collaborators Oct 25, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Ahdhn Ahdhn Ahdhn approved these changes

Assignees

@massimim massimim

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@massimim @Ahdhn