Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove redundant operations from PathCost private constructor. #5

Merged
merged 1 commit into from
May 21, 2024

Conversation

wmamrak
Copy link
Contributor

@wmamrak wmamrak commented May 20, 2024

If there is a reason for that cast to double and truncation, I would be really glad to know. 🙂

Copy link

github-actions bot commented May 20, 2024

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@wmamrak
Copy link
Contributor Author

wmamrak commented May 20, 2024

I have read the CLA Document and I hereby sign the CLA

@rhysgoldstein rhysgoldstein self-assigned this May 21, 2024
@rhysgoldstein rhysgoldstein self-requested a review May 21, 2024 15:30
Copy link
Contributor

@rhysgoldstein rhysgoldstein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree that the cast to double and truncation were redundant, the result of an oversight. Removing these operations should improve performance without affecting the output.

@rhysgoldstein rhysgoldstein merged commit 107ef6e into Autodesk:main May 21, 2024
10 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators May 21, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants