Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unnecessary specifier. #168

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

Remove unnecessary specifier. #168

wants to merge 2 commits into from

Conversation

zpgit
Copy link

@zpgit zpgit commented Oct 8, 2021

The unsafe specifier in C# binding is unnecessary.

@martinweismann PTAL.

@zpgit zpgit requested a review from martinweismann October 8, 2021 09:29
@martinweismann
Copy link
Member

martinweismann commented Oct 8, 2021

Unfortunately, and against my previous investigation, there is a problem with this PR:

Error CS0214 Pointers and fixed size buffers may only be used in an unsafe context

image

Any idea to work around that @zpgit ?

@zpgit
Copy link
Author

zpgit commented Oct 27, 2021

Unfortunately, and against my previous investigation, there is a problem with this PR:

Error CS0214 Pointers and fixed size buffers may only be used in an unsafe context

image

Any idea to work around that @zpgit ?

Hi @martinweismann ,
As we discussed on slack, I have merged the change from Pavlo to this pull request.
Please take another look. Thanks.

zpgit added 2 commits August 26, 2022 09:27
The unsafe specifier in C# binding is unnecessary.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants