Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fixed broken links and table of contents #616

Merged
merged 2 commits into from
Jun 7, 2024

Conversation

chadcwilliams
Copy link
Collaborator

Description

Fixed broken links and broken table of contents in the 4 basic tutorials

If the issue is on Github, simply link to it using the '#' symbol; otherwise, provide a notion page link):

  • No issue made (whoops)

Type of change

  • fix: A bug fix

Copy link
Collaborator

@musslick musslick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

Copy link
Member

@hollandjg hollandjg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey Chad, thanks for putting these changes together! The changes you made make sense.

It looks like you've removed the output from the notebooks, and that means that they will render without the graphs on the web. I don't think that's intended. If you just rerun all the notebooks and save them with the output, then the graphs will reappear.

@chadcwilliams
Copy link
Collaborator Author

Hey Chad, thanks for putting these changes together! The changes you made make sense.

It looks like you've removed the output from the notebooks, and that means that they will res nder without the graphs on the web. I don't think that's intended. If you just rerun all the notebooks and save them with the output, then the graphs will reappear.

This actually was on purpose because we have nb-clean as part of our commit pipeline, but now that you mention it that definitely doesn't make sense in this case. Just committed with the outputs back in!

@musslick musslick requested a review from hollandjg June 5, 2024 08:08
Copy link
Member

@hollandjg hollandjg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@musslick musslick added this pull request to the merge queue Jun 7, 2024
Merged via the queue into main with commit cbffef6 Jun 7, 2024
15 checks passed
@musslick musslick deleted the bugfix/fix-tutorial-bugs branch June 7, 2024 09:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants