Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: make return values of sampler and pooler pd.Dataframe #26

Merged
merged 3 commits into from
Jul 26, 2024
Merged

feat: make return values of sampler and pooler pd.Dataframe #26

merged 3 commits into from
Jul 26, 2024

Conversation

younesStrittmatter
Copy link
Contributor

The return values are now pd.Dataframe

Question:
The return value of the pooler was an iter. Was there a specific reason for this?

@younesStrittmatter younesStrittmatter linked an issue Jul 26, 2024 that may be closed by this pull request
make-return-value-dataframe #25
Closed
musslick
musslick approved these changes Jul 26, 2024
View reviewed changes
Copy link
Contributor

@musslick musslick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much for fixing all these!

@younesStrittmatter younesStrittmatter merged commit efdb238 into main Jul 26, 2024
12 checks passed
@younesStrittmatter younesStrittmatter deleted the 25-make-return-value-dataframe branch July 26, 2024 17:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@musslick musslick musslick approved these changes

@blinodelka blinodelka Awaiting requested review from blinodelka

@whyhardt whyhardt Awaiting requested review from whyhardt

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

make-return-value-dataframe
2 participants
@younesStrittmatter @musslick