Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add ability to add fields to StateDataClass #47

Closed
wants to merge 8 commits into from
Closed

feat: add ability to add fields to StateDataClass #47

wants to merge 8 commits into from

Conversation

hollandjg
Copy link
Member

@hollandjg hollandjg commented Nov 8, 2023 •
edited
Loading

Add a new method to the StateDataClass which returns a copy of the dataclass with a new field.
Supports delta and converter, but not aliases (which are hard to pickle and which we've posited we'll remove in a separate PR).

@hollandjg hollandjg marked this pull request as ready for review November 8, 2023 20:13
@hollandjg hollandjg closed this Nov 29, 2023
@hollandjg
Copy link
Member Author

hollandjg commented Nov 29, 2023 •
edited
Loading

Closing this as we can't add fields and still retain saving and loading.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@musslick musslick Awaiting requested review from musslick

@benwandrew benwandrew Awaiting requested review from benwandrew

@younesStrittmatter younesStrittmatter Awaiting requested review from younesStrittmatter

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hollandjg @benwandrew