Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Do deterministic inference #25

Merged
merged 7 commits into from
Jan 17, 2024
Merged

feat: Do deterministic inference #25

merged 7 commits into from
Jan 17, 2024

Conversation

carlosgjs
Copy link
Collaborator

@carlosgjs carlosgjs commented Jan 11, 2024

  • Expose the do_sample argument in the CLI and AML jobs
  • Switch default to do_sample=False to have deterministic outputs.
  • Add first AutoRA example to the data (and add a small command to command to do so)

@carlosgjs carlosgjs requested a review from anujsinha3 January 11, 2024 20:37
@codecov-commenter
Copy link

codecov-commenter commented Jan 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (89899bb) 95.83% compared to head (81fb31f) 96.15%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #25      +/-   ##
==========================================
+ Coverage   95.83%   96.15%   +0.32%     
==========================================
  Files           3        3              
  Lines         120      130      +10     
==========================================
+ Hits          115      125      +10     
  Misses          5        5              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@carlosgjs carlosgjs marked this pull request as ready for review January 11, 2024 21:29
@carlosgjs carlosgjs requested review from lsetiawan and uwcdc January 11, 2024 22:23
Copy link
Collaborator

@lsetiawan lsetiawan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Just had a minor adjustment. It's up to you if it's important enough to implement 😄

carlosgjs and others added 2 commits January 12, 2024 15:25
Co-authored-by: Don Setiawan <[email protected]>
@carlosgjs carlosgjs merged commit fdcce7e into main Jan 17, 2024
9 checks passed
@carlosgjs carlosgjs deleted the carlosg/determ branch January 17, 2024 00:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants