fix: update kafka instance version (#49)

AutoMQ · Oct 14, 2024 · 89e1ef6 · 89e1ef6
1 parent df53c76
commit 89e1ef6
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 6 deletions.
diff --git a/client/api_kafka_instance.go b/client/api_kafka_instance.go
@@ -122,13 +122,17 @@ func (c *Client) GetInstanceConfigs(ctx context.Context, instanceId string) ([]C
 	return instance.List, nil
 }
 
-func (c *Client) UpdateKafkaInstanceBasicInfo(ctx context.Context, instanceId string, updateParam InstanceBasicParam) (*KafkaInstanceResponse, error) {
-	return c.updateInstance(ctx, instanceId, updateParam, UpdateInstanceBasicInfoPath)
+func (c *Client) UpdateKafkaInstanceVersion(ctx context.Context, instanceId string, version string) error {
+	updateParam := InstanceVersionUpgradeParam{Version: version}
+	_, err := c.Put(ctx, fmt.Sprintf(UpdateInstanceVersionPath, instanceId, version), updateParam)
+	if err != nil {
+		return err
+	}
+	return nil
 }
 
-func (c *Client) UpdateKafkaInstanceVersion(ctx context.Context, instanceId string, version string) (*KafkaInstanceResponse, error) {
-	updateParam := InstanceVersionUpgradeParam{Version: version}
-	return c.updateInstance(ctx, instanceId, updateParam, UpdateInstanceVersionPath)
+func (c *Client) UpdateKafkaInstanceBasicInfo(ctx context.Context, instanceId string, updateParam InstanceBasicParam) (*KafkaInstanceResponse, error) {
+	return c.updateInstance(ctx, instanceId, updateParam, UpdateInstanceBasicInfoPath)
 }
 
 func (c *Client) UpdateKafkaInstanceConfig(ctx context.Context, instanceId string, updateParam InstanceConfigParam) (*KafkaInstanceResponse, error) {

diff --git a/internal/provider/resource_instance.go b/internal/provider/resource_instance.go
@@ -467,7 +467,7 @@ func (r *KafkaInstanceResource) Update(ctx context.Context, req resource.UpdateR
 	planVersion := plan.ComputeSpecs.Version.ValueString()
 	stateVersion := state.ComputeSpecs.Version.ValueString()
 	if planVersion != "" && planVersion != stateVersion {
-		_, err = r.client.UpdateKafkaInstanceVersion(ctx, state.InstanceID.ValueString(), planVersion)
+		err = r.client.UpdateKafkaInstanceVersion(ctx, state.InstanceID.ValueString(), planVersion)
 		if err != nil {
 			resp.Diagnostics.AddError("Client Error", fmt.Sprintf("Unable to update Kafka instance %q, got error: %s", instanceId, err))
 			return