feat: seal period

Aut-Labs · Aug 12, 2024 · 675b4eb · 675b4eb
1 parent b2b70c6
commit 675b4eb
Show file tree

Hide file tree

Showing 2 changed files with 42 additions and 0 deletions.
diff --git a/contracts/nova/INova.sol b/contracts/nova/INova.sol
@@ -17,6 +17,7 @@ interface INova {
     error InvalidPeriodId();
     error TaskNotActive();
     error MemberHasNotYetCommited();
+    error PeriodAlreadySealed();
     error UnequalLengths();
 
     event AdminGranted(address to);

diff --git a/contracts/nova/Nova.sol b/contracts/nova/Nova.sol
@@ -65,6 +65,7 @@ contract Nova is INova, NovaUtils, NovaUpgradeable {
 
     struct PeriodSummary {
         bool inactive;
+        bool isSealed;
         uint128 sumCommitmentLevel;
         uint128 sumCreatedContributionPoints;
         uint128 sumActiveContributionPoints;
@@ -399,6 +400,7 @@ contract Nova is INova, NovaUtils, NovaUpgradeable {
             // Write data to oldest possible period summary with no data
             periodSummaries[i] = PeriodSummary({
                 inactive: false,
+                isSealed: false,
                 sumCommitmentLevel: currentSumCommitmentLevel,
                 sumActiveContributionPoints: currentSumActiveContributionPoints,
                 sumCreatedContributionPoints: currentSumCreatedContributionPoints,
@@ -411,6 +413,7 @@ contract Nova is INova, NovaUtils, NovaUpgradeable {
                 for (uint32 j = i + 1; j < _currentPeriodId; j++) {
                     periodSummaries[j] = PeriodSummary({
                         inactive: true,
+                        isSealed: true,
                         sumCommitmentLevel: currentSumCommitmentLevel,
                         sumCreatedContributionPoints: 0,
                         sumActiveContributionPoints: currentSumActiveContributionPoints,
@@ -427,6 +430,44 @@ contract Nova is INova, NovaUtils, NovaUpgradeable {
         }
     }
 
+    function canSeal(uint32 periodId) external view returns (bool) {
+        PeriodSummary memory periodSummary = periodSummaries[periodId];
+        if (periodSummary.isSealed) return false;
+        uint256 length = members.length;
+        for (uint256 i=0; i<length; i++) {
+            if (participations[members[i]][periodId].score == 0) {
+                return false;
+            }
+        }
+        return true;
+    }
+
+    function getMembersToWriteParticipation(uint32 periodId) external view returns (address[] memory) {
+        uint256 numMembersToWrite = 0;
+        uint256 length = members.length;
+        address[] memory membersCopy = new address[](length);
+        for (uint256 i=0; i<length; i++) {
+            address member = members[i];
+            if (participations[member][periodId].score == 0) {
+                membersCopy[numMembersToWrite++] = member;
+            }
+        }
+
+        address[] memory arrMembersToWrite = new address[](numMembersToWrite);
+        for (uint256 i=0; i<numMembersToWrite; i++) {
+            arrMembersToWrite[i] = membersCopy[i];
+        }
+        return arrMembersToWrite;
+    }
+
+    // TODO: role other than admin?
+    function seal(uint32 periodId) external {
+        _revertForNotAdmin(msg.sender);
+        PeriodSummary storage periodSummary = periodSummaries[periodId];
+        if (periodSummary.isSealed) revert PeriodAlreadySealed();
+        periodSummary.isSealed = true;
+    }
+
     function currentTaskId() public view returns (uint256) {
         return tasks.length - 1;
     }