Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor bugfixes #11

Merged
merged 5 commits into from
Jun 19, 2024
Merged

Minor bugfixes #11

merged 5 commits into from
Jun 19, 2024

Conversation

tclose
Copy link
Contributor

@tclose tclose commented Jun 18, 2024

  • fixes default option for SSL verification
  • drops --delete option from upload cli
  • catch dicom metadata processing errors on XNAT and raise warnings instead
  • adds '--add-logger' flag for adding logs for additional packages (e.g. 'xnat')

Copy link

codecov bot commented Jun 18, 2024

Codecov Report

Attention: Patch coverage is 70.96774% with 9 lines in your changes missing coverage. Please review.

Project coverage is 76.41%. Comparing base (3734bed) to head (0a20401).

Files Patch % Lines
xnat_ingest/cli/upload.py 60.00% 6 Missing ⚠️
xnat_ingest/utils.py 80.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #11      +/-   ##
==========================================
+ Coverage   76.20%   76.41%   +0.21%     
==========================================
  Files          13       13              
  Lines        1080     1094      +14     
==========================================
+ Hits          823      836      +13     
- Misses        257      258       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tclose tclose merged commit 25549d6 into main Jun 19, 2024
6 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant