Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed up caching, so that different header values are cached separately #12

Merged
merged 3 commits into from
Sep 27, 2024

Conversation

tclose
Copy link
Contributor

@tclose tclose commented Sep 27, 2024

No description provided.

@tclose tclose merged commit 0264f09 into main Sep 27, 2024
9 checks passed
@codecov-commenter
Copy link

codecov-commenter commented Sep 27, 2024

Codecov Report

Attention: Patch coverage is 82.35294% with 3 lines in your changes missing coverage. Please review.

Project coverage is 64.54%. Comparing base (d9218a4) to head (69b2617).
Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
medimages4tests/dummy/dicom/base.py 57.14% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #12      +/-   ##
==========================================
+ Coverage   64.33%   64.54%   +0.20%     
==========================================
  Files          31       31              
  Lines         429      440      +11     
  Branches       59       61       +2     
==========================================
+ Hits          276      284       +8     
- Misses        133      135       +2     
- Partials       20       21       +1     
Flag Coverage Δ
64.31% <82.35%> (+0.21%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tclose tclose deleted the fix-dicom-write branch September 28, 2024 03:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants