Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added check for pydicom version before using enforce pydicom write #10

Merged
merged 1 commit into from
Sep 24, 2024

Conversation

tclose
Copy link
Contributor

@tclose tclose commented Sep 24, 2024

The write options changed in pydicom v3~ and so we need to check which one we are using before selecting the appropriate option

@tclose tclose merged commit 55f0a79 into main Sep 24, 2024
9 checks passed
@codecov-commenter
Copy link

codecov-commenter commented Sep 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 64.94%. Comparing base (5f2dc78) to head (4f5db62).
Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #10   +/-   ##
=======================================
  Coverage   64.94%   64.94%           
=======================================
  Files          31       31           
  Lines         425      425           
  Branches       58       58           
=======================================
  Hits          276      276           
  Misses        129      129           
  Partials       20       20           
Flag Coverage Δ
64.70% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants