Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue#76 #80

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Issue#76 #80

wants to merge 2 commits into from

Conversation

fxusyd
Copy link
Contributor

@fxusyd fxusyd commented Mar 13, 2022

No description provided.

@exxa-tech
Copy link
Contributor

Hi Fang,

{{- /* annotations:
service.beta.kubernetes.io/aws-load-balancer-type: "nlb"
service.beta.kubernetes.io/aws-load-balancer-nlb-target-type: "instance"
service.beta.kubernetes.io/aws-load-balancer-scheme: "internet-facing"
service.beta.kubernetes.io/aws-load-balancer-ssl-cert: "arn:aws:acm:ap-southeast-2:078690265916:certificate/661ff0de-361d-48da-9424-bb274dc172c2"
service.beta.kubernetes.io/aws-load-balancer-ssl-negotiation-policy: "ELBSecurityPolicy-2016-08"

This is for AWS EKS ALB specifically so should not be in a template file. The Helm chart should at least try to be platform agnostic as much as possible.

You didn't update the Chart.yaml version number!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants