Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deconstructable Shutters #19969

Open
wants to merge 18 commits into
base: master
Choose a base branch
from
Open

Conversation

hazelrat
Copy link
Contributor

Introduces a way to deconstruct shutters with a welding torch. Takes 90 seconds in total, split into 15 seconds chunks so being pushed off the tile doesn't lose you over a minute of progress. Extends only to shutters, not blast doors.

@hazelrat
Copy link
Contributor Author

!review

code/game/machinery/doors/blast_door.dm Outdated Show resolved Hide resolved
code/game/machinery/doors/blast_door.dm Show resolved Hide resolved
code/game/machinery/doors/blast_door.dm Show resolved Hide resolved
code/game/machinery/doors/blast_door.dm Outdated Show resolved Hide resolved
code/game/machinery/doors/blast_door.dm Outdated Show resolved Hide resolved
code/game/machinery/doors/blast_door.dm Outdated Show resolved Hide resolved
code/game/machinery/doors/blast_door.dm Outdated Show resolved Hide resolved
code/game/machinery/doors/blast_door.dm Outdated Show resolved Hide resolved
code/game/machinery/doors/blast_door.dm Outdated Show resolved Hide resolved
@hazelrat
Copy link
Contributor Author

hazelrat commented Oct 5, 2024

@FluffyGhoster Changes implemented.

code/game/machinery/doors/blast_door.dm Outdated Show resolved Hide resolved
code/game/machinery/doors/blast_door.dm Outdated Show resolved Hide resolved
@hazelrat
Copy link
Contributor Author

hazelrat commented Oct 6, 2024

@Geevies Both suggestions implemented

code/game/machinery/doors/blast_door.dm Outdated Show resolved Hide resolved
@Arrow768
Copy link
Member

Arrow768 commented Oct 7, 2024

If deconstruction is added, construction if shutters need to be added aswell to allow repairs

@Arrow768 Arrow768 added Changes Required The PR requires changes before it can be approved and/or merged. and removed Awaiting Merge labels Oct 7, 2024
Copy link
Member

@Arrow768 Arrow768 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comment above.
If deconstruction is added, construction is also required

@hazelrat
Copy link
Contributor Author

hazelrat commented Oct 8, 2024

See comment above. If deconstruction is added, construction is also required

Shutters work off buttons, which are themselves impossible to construct and are linked to their shutters with an ID variable. To do this I'd need to also allow the editing of the ID variable for shutters based on the IDs of buttons, and giving buttons a reprogrammable functionality would increase the scope of this very drastically. I can think of ways to do it, but I think it's very out of scope for this PR.

Shutters can already be constructed with an emitter, any other projectile, or with explosives. This is primarily just to make #19885 more palatable by allowing antagonists to be able to get through shutters without needing to use C4.

@hazelrat
Copy link
Contributor Author

See comment above. If deconstruction is added, construction is also required

Shutters work off buttons, which are themselves impossible to construct and are linked to their shutters with an ID variable. To do this I'd need to also allow the editing of the ID variable for shutters based on the IDs of buttons, and giving buttons a reprogrammable functionality would increase the scope of this very drastically. I can think of ways to do it, but I think it's very out of scope for this PR.

Shutters can already be constructed with an emitter, any other projectile, or with explosives. This is primarily just to make #19885 more palatable by allowing antagonists to be able to get through shutters without needing to use C4.

@Arrow768 With this in mind, do your required changes stand?

@Arrow768
Copy link
Member

Arrow768 commented Nov 6, 2024

See comment above. If deconstruction is added, construction is also required

Shutters work off buttons, which are themselves impossible to construct and are linked to their shutters with an ID variable. To do this I'd need to also allow the editing of the ID variable for shutters based on the IDs of buttons, and giving buttons a reprogrammable functionality would increase the scope of this very drastically. I can think of ways to do it, but I think it's very out of scope for this PR.
Shutters can already be constructed with an emitter, any other projectile, or with explosives. This is primarily just to make #19885 more palatable by allowing antagonists to be able to get through shutters without needing to use C4.

@Arrow768 With this in mind, do your required changes stand?

Yes, the changes requires still applies, as there is imho a significant difference between setting up an emitter/using c4 to "deconstruct" shutters and actually being able to deconstruct them with just a welder.

The emitter requires a reasonable amount of time to acquire, set up properly and then break through the shutter and the C4 is a limited use item, thereby making breaking through shutters a very rare event.
By just requiring a welder this is going to become a more common occurrence and as such it needs to be possible to repair the expected damage.

If you do not want to add a "full" construction mechanic due to the complexity involved (*1), an alternative would be to not fully deconstruct the shutter and instead leave behind non-functional remains, that can be repaired (instead of deleting the shutter).

*1: It could be as simple as using a multitool on a button to save the id and then applying the multitool to the shutter under construction at a certain point to set the shutter to that saved id. (or add a circuit board required to build a shutter to maintain consistency with other machinery construction where the id is encoded to in the previously described manner)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changes Required The PR requires changes before it can be approved and/or merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants