-
Notifications
You must be signed in to change notification settings - Fork 518
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds an autocannon ship gun #19927
Merged
Merged
Adds an autocannon ship gun #19927
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hazelrat
requested review from
alsoandanswer and
NonQueueingMatt
as code owners
September 21, 2024 17:09
!wip |
BotBOREALIS
added
the
WIP
The PR is a work in progress and should not be reviewed yet.
label
Sep 21, 2024
!review |
BotBOREALIS
added
Review Required
and removed
WIP
The PR is a work in progress and should not be reviewed yet.
labels
Sep 22, 2024
Geevies
approved these changes
Sep 23, 2024
FluffyGhoster
requested changes
Sep 24, 2024
NonQueueingMatt
approved these changes
Sep 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the Goshawk heavy autocannon to the game, intended as a generic gun emplacement available to be mapped into any appropriate offship.
The AP shots are intended to be the weakest, but they do a lot of damage on the off-chance they do hit someone. AP fires twelve shots, frag fires nine, and HE only fires six - obviously ICly every salvo is the same size, this is just for balance. As is currently, I'd say this is a little stronger and generally a bit more versatile than the grauwolf.
This is up for review.
Credit to Noble for the spriting!