Ports 8 hairstyles from Citadel #19205
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
!review |
|
It somewhat feels as if all five of these hairstyles should just be "Blank 1 - 5", since they're so similar. (Or at least the bottom 4, unsure about the top one.) |
|
As Stev above says. They are pretty similar so yes, they should have names like "XXX 1", "XXX 2", ... etc. Better for organization. |
|
Agreed, should name them like |
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
Arrow768
previously requested changes
May 31, 2024
|
My Github Desktop was having issues, but I think I've done it now. |
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
NonQueueingMatt
approved these changes
Jun 3, 2024
Geevies
approved these changes
Jun 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From Citadel-Station-13/Citadel-Station-13-RP#6109
To address the elephant in the room; yes, these are reference hairs. I think they should get in anyway because they look good, we don't have enough good hairstyles, and we literally have Vegeta hair titled 'Vegeta' ingame already. I can rename them if you suggest new names, if that is preferred. I just couldn't think of any.
Accidentally deleted the branch. Oopsies! Old PR: #19204