Graph tls changes #1
Conversation
| @@ -218,7 +227,7 @@ function onnewsession(key, session) { | |||
| var once = false; | |||
|
|
|||
| this._newSessionPending = true; | |||
| if (!this.server.emit('newSession', key, session, done)) | |||
| if (!this.server.emit('newSession', key, session, self, done)) | |||
| self.server && | ||
| !self.server.emit('resumeSession', hello.sessionId, onSession)) { | ||
| !self.server.emit('resumeSession', hello.tlsTicket || hello.sessionId, self, onSession)) { |
There was a problem hiding this comment.
Partially original sessionID change
| @@ -97,9 +97,9 @@ function loadSession(self, hello, cb) { | |||
| } | |||
|
|
|||
| if (hello.sessionId.length <= 0 || | |||
| hello.tlsTicket || | |||
| // hello.tlsTicket || | |||
There was a problem hiding this comment.
This was added in nodejs@dda22a5 to prevent resumeSession being executed on Session Tickets, but we want that to happen.
| @@ -167,7 +169,7 @@ void ClientHelloParser::ParseExtension(const uint16_t type, | |||
| break; | |||
| case kTLSSessionTicket: | |||
| tls_ticket_size_ = len; | |||
| tls_ticket_ = data + len; | |||
| tls_ticket_ = data; | |||
There was a problem hiding this comment.
90% sure this was a small bug in node that was never being used for anything. Maybe I'll make a PR on some new Github account and actually contribute to open source node.
| size_t key_name_offset = 16; | ||
| // IV is the only part we are actually going to take | ||
| size_t key_iv_size = 16; | ||
| buff = Buffer::Copy( |
There was a problem hiding this comment.
We strip the IV from the session ticket and expose it as part of the ClientHello object that propagates to JS land
src/tls_wrap.cc
Outdated
| // New Session Ticket | ||
| // https://www.ietf.org/rfc/rfc5077.txt | ||
| // TODO base this on the actual packet, not length | ||
| if (write_size_ == 258) { |
There was a problem hiding this comment.
This is the real hack. We listen to all socket output for New Session Ticket events, and strip the IV from the ticket and call our function in JS land that simulates a newSession.
|
great work ⭐️ |
This PR will be kept open and maintained and releases of the
observer-poolwill be from the branchgraph-tls-changes