Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

define service_longname when service specified #57

Merged
merged 1 commit into from
Sep 26, 2024
Merged

Conversation

Audionut
Copy link
Owner

fixes #56

If --service is argumented, service_longname is not set in the meta causing error

if str(meta['service_longname']) != "":

I'm really lost as to what the intended purpose was here. If I just keyed like the existing logic, it would key from the first key, and just use CR, being the first key, instead of the services long name, Crunchy Roll, (since every service long_name key is duplicated from an abbreviated service key).

If I manually set --service "Crunchy Roll", then it would use "Crunchy Roll" for both the service and service_longname meta.

What on earth was the purpose of service_longname if it's just set as the abbreviated service name.......And if you service the longname, why didn't it use the abbreviated service name for the service meta.

This PR sets the service longname to the actual service longname when the argument --service is used.

@Audionut Audionut merged commit 3a4bebe into master Sep 26, 2024
1 check passed
@Audionut Audionut deleted the service_longname branch September 26, 2024 09:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MTV upload failing with KeyError: 'service_longname'
1 participant