Torrent upload & upload error improvments #222
Closed
+748
−341
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
My implementation of this wasn't correctly handling MTV (and probably every other HTTP site). Whilst it worked quite well, saving the odd second isn't worth the hassle of trying to correct HTTP sites and then dealing with the enviable bugs I would have created. Properly skipping addition of torrent to client on error is still to be implemented in another pr. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It annoys me when there is some error on uploading, but the torrent is still added to client. This PR serves to fix that.
First push catches resolution checking at ULCX.
I initially decided against asyncing uploading/adding to client, but this PR will also serve to async that process.