Update test to handle content disposition with no properties

Addresses issue in DockYard#154
Audian · Aug 10, 2023 · 5154618 · 5154618
1 parent db7b4e7
commit 5154618
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 1 deletion.
diff --git a/lib/mail.ex b/lib/mail.ex
@@ -225,7 +225,7 @@ defmodule Mail do
       case Mail.Message.is_attachment?(message) do
         true ->
           filename =
-            case Mail.Message.get_header(message, :content_disposition) do
+            case List.wrap(Mail.Message.get_header(message, :content_disposition)) do
               ["attachment" | properties] ->
                 Enum.find_value(properties, "Unknown", fn {key, value} ->
                   key == "filename" && value

diff --git a/test/mail_test.exs b/test/mail_test.exs
@@ -485,6 +485,9 @@ defmodule MailTest do
         "attachment"
       ])
       |> Mail.Message.put_header(:content_transfer_encoding, :base64)
+      # We render and parse so we have the attachment with no properties
+      |> Mail.render()
+      |> Mail.parse()
 
     [attachment | _] = Mail.get_attachments(mail)
     assert attachment == file