Fixed Windows UDP unicast only working on a single network interface #345
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removed the logic that tries to bind all interfaces to a UDP socket on Windows. I do not understand why this would be necessary. The result seems to be that the socket binds to the earliest listed interface it can bind to and fails all other interfaces. Binding to "0.0.0.0" works on Windows so I removed the conditional compilation syntax.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #345 +/- ##
==========================================
- Coverage 73.53% 71.27% -2.27%
==========================================
Files 94 93 -1
Lines 19845 18504 -1341
==========================================
- Hits 14594 13189 -1405
- Misses 5251 5315 +64 ☔ View full report in Codecov by Sentry. |
|
Thank you for the contribution. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed the logic that tries to bind all interfaces to a UDP socket on Windows. I do not understand why this would be necessary. The result seems to be that the socket binds to the earliest listed interface it can bind to and fails all other interfaces. This means that RustDDS fails to send unicast UDP messages to any devices that are not available to that first interface. Binding to "0.0.0.0" works on Windows so I removed the conditional compilation syntax. The fact that this code was present leads me to believe that this fixed something earlier, right now I cannot determine what this was.