Feature/#777 #783
Feature/#777 #783
Conversation
Adding fathom analytics
| @@ -34,6 +34,7 @@ class ApiController extends BaseController { | |||
| MapService mapService | |||
| ApiService apiService | |||
|
|
|||
| @RequireApiKey() | |||
There was a problem hiding this comment.
why is requireapikey required? Similarly other below actions.
There was a problem hiding this comment.
previous ApiController class had @RequireApiKey. so I put it into all method except api/opus/list
There was a problem hiding this comment.
Keep security standard for all actions.
| @@ -106,6 +107,41 @@ class ApiController extends BaseController { | |||
| } | |||
| } | |||
|
|
|||
| @Path("/api/opus/list") | |||
There was a problem hiding this comment.
rename to /api/opus for consistency with other APIs
| @@ -106,6 +107,41 @@ class ApiController extends BaseController { | |||
| } | |||
| } | |||
|
|
|||
| @Path("/api/opus/list") | |||
| @Operation( | |||
| summary = "Get all collection (opus) details", | |||
There was a problem hiding this comment.
Perhaps better to reword it to Get all public collections
| ] | ||
| ) | ||
| def getListCollections () { | ||
| List opus = profileService.getOpusList() as List |
There was a problem hiding this comment.
Reuse profileService.getOpus(). No need to implement a custom code in profile-hub or profile-service.
| @@ -26,6 +26,8 @@ class ApiInterceptor { | |||
| Class controllerClass = controller?.clazz | |||
| def method = controllerClass?.getMethod(actionName, [] as Class[]) | |||
|
|
|||
| if (method.name == "getListCollections") return true | |||
There was a problem hiding this comment.
should not escape api interceptor logic.
| @@ -45,6 +45,11 @@ class ProfileService { | |||
| webServiceWrapperService.get("${grailsApplication.config.profile.service.url}/opus/${encPath(opusId)}", [:], ContentType.APPLICATION_JSON, true, false, getCustomHeaderWithUserId())?.resp | |||
| } | |||
|
|
|||
| def getOpusList() { | |||
| @@ -263,6 +263,7 @@ class UrlMappings { | |||
| get "/opus/$opusId/profile/$profileId/image" (version: "1.0", controller: "api", action: "getImages", namespace: "v1") | |||
| get "/opus/$opusId/profile/$profileId/attribute/$attributeId" (version: "1.0", controller: "api", action: "getAttributes", namespace: "v1") | |||
| get "/opus/$opusId/profile/$profileId/draft" (version: "1.0", controller: "api", action: "getDraftProfile", namespace: "v1") | |||
| get "/opus/list" (version: "1.0", controller: "api", action: "getListCollections", namespace: "v1") | |||
| @@ -333,6 +370,7 @@ class ApiController extends BaseController { | |||
| } | |||
| } | |||
|
|
|||
| @RequireApiKey() | |||
There was a problem hiding this comment.
Remove. applies to other implementations.
| @@ -0,0 +1,12 @@ | |||
| package au.org.ala.profile.domain | |||
There was a problem hiding this comment.
Move this class to src/main/groovy/au/org/ala/profile/api/.
| mediaType = "application/json", | ||
| array = @ArraySchema( | ||
| schema = @Schema( | ||
| implementation = OpusResponse.class |
There was a problem hiding this comment.
Replace with CollectionList since OpusResponse has a lost more properties than what is returned by this API.
| @@ -1,4 +1,4 @@ | |||
| package au.org.ala.profile.domain | |||
| package au.org.ala.profile.api | |||
There was a problem hiding this comment.
The location is not correct. Should not place this file with controllers. See comment before to get exact location.
Would you be able to get PR?