Feature/issue1001 #1002
Merged
Feature/issue1001 #1002
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Services and Targets #918
chrisala
requested changes
Aug 27, 2024
| @@ -437,7 +437,7 @@ class ValidationHandler implements OutputModelProcessor.Processor<ExcelValidatio | |||
|
|
|||
| @Override | |||
| def text(Object node, ExcelValidationContext context) { | |||
| if (node.constraints) { | |||
| if (node.constraints && node.constraints instanceof org.grails.web.json.JSONObject == false) { | |||
There was a problem hiding this comment.
Introducing this condition will break the download of computed constraints with options (the next if statement on line 443).
As an aside, you should be using Map as a test, not JSONObject as the issue is casting a Map to a List, not the specific implementation of a Map.
There was a problem hiding this comment.
Thanks for pointing me that out, I just saw that the ESP SMU Reporting has a computed type constraints.
I've updated the validation for the pre-populated constraints type.
chrisala
approved these changes
Aug 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.