Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/hcat #1591

Merged
merged 26 commits into from
Apr 28, 2024
Merged

Feature/hcat #1591

merged 26 commits into from
Apr 28, 2024

Conversation

jack-brinkman
Copy link
Contributor

  • Added ReferenceAssessmentController for HCAT implementation
  • Added configuration option to hide 'Add new record' button on activity view page
  • Fixed authentication issue with static page edit functionality
  • Fixed chromedriver build issues

jack-brinkman and others added 25 commits January 22, 2024 13:29
…d integer casting of maxRecordsToCreate config property
Copy link
Contributor

@temi temi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. My general comments is to add a mongo script in release folder that will update the content of image assessment static page. See merit example here.

}

def requestRecords() {
def config = grailsApplication.config.refAssess
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use getProperty to get config items. grailsApplication.config.getProperty("refAssess", Map). A few instances of this are in the code

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

@jack-brinkman jack-brinkman merged commit 0b99dfe into develop Apr 28, 2024
1 check passed
@jack-brinkman jack-brinkman deleted the feature/hcat branch July 23, 2024 06:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants