-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature my annotation #435
Merged
alexhuang091
merged 26 commits into
AtlasOfLivingAustralia:develop
from
alexhuang091:feature_my_annotation
Apr 13, 2021
Merged
Changes from 25 commits
Commits
Show all changes
26 commits
Select commit
Hold shift + click to select a range
792aae6
Increment version number for next development iteration
sbearcsiro d287374
AtlasOfLivingAustralia/DataQuality#182 Add duplicate assertion type t…
sbearcsiro 419e470
AtlasOfLivingAustralia/DataQuality#208 Add duplicate user assertion s…
sbearcsiro 3af21a1
AtlasOfLivingAustralia/DataQuality#187 Add duplicate reason to duplic…
sbearcsiro 1e4bd59
AtlasOfLivingAustralia/DataQuality#208 Add duplicate reason display
sbearcsiro 34c49b7
AtlasOfLivingAustralia/DataQuality#187 Lower logging level for exists…
sbearcsiro cf43901
AtlasOfLivingAustralia/DataQuality#214 preview record when flagging a…
sbearcsiro b313e76
AtlasOfLivingAustralia/DataQuality#187 Review feedback
sbearcsiro df1e332
Feature my annotations (#391)
alexhuang091 e4c4e1d
removed unused param from processUserFQInteraction
alexhuang091 1feef6f
updated biocache-hubs to use dq-client 1.1.0 with user profile feature
alexhuang091 a787499
changes needed for my annotation changes on alerts side
alexhuang091 45c3c1b
Merge remote-tracking branch 'remotes/origin/dq_feature_user_profile'…
alexhuang091 1157eae
to use dq-service-client 1.2.0-SNAPSHOT for user-specific profile
alexhuang091 a037da3
Refined the way apiKey is set in ApiClient
alexhuang091 72bc136
removed 'myannotation.name' which is never used.
alexhuang091 693320f
Merge pull request #401 from alexhuang091/feature/data-quality
alexhuang091 b9fad6d
fixed an issue when disableAllQualityFilters = true
alexhuang091 bebd021
UI update for flag a duplicate record & DQ#217
alexhuang091 12e7113
DQ#217, handle 'user input id retrieves more than 1 record'
alexhuang091 3db615c
fixed an issue in displaying comment.
alexhuang091 5ced833
Merge remote-tracking branch 'upstream/develop' into feature/data-qua…
alexhuang091 cd1bdd2
Merge branch 'feature/data-quality' into feature_my_annotation
alexhuang091 fed9e31
do alerts related url mappings conditionally
alexhuang091 9e24459
fixed typo
alexhuang091 5bb0a83
alerts API names changed so we need to update accordingly
alexhuang091 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure I understand why this is a
delete
operation. I thought "my annotations" was a permanent alert type that is either on or off. It seems strange to delete it...There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi Nick, yes we can turn it on/off.
On alerts side, it's like a custom query since different user has different query_url (...assertion_user_id=xxx).
So
addMyAnnotaionAlert
) a query is created inalerts
.deleteMyAnnotationAlert
) that query inalerts
is deleted (actually query + notification + queryresult all deleted. Delete notification is enough for stopping getting notification though)There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK can leave it as is... I'd argue the public interface for the service should just be on/off, as the client doesn't need to know that records are being added and then deleted.... it makes it seem more complex and potentially confusing for clients to implement - "Why is it deleting the annotation? Will the user never be able to turn it on again in the future if its deleted?" I had these questions when I read the code...