Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

79 404 pages are showing default grails skin with broken images #80

Merged
merged 2 commits into from
Aug 16, 2024
Merged

79 404 pages are showing default grails skin with broken images #80

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6d7451a
#79 Fix for broken styling on error and 404 pages
nickdos Aug 16, 2024
d5c60e3
#79 Minor CSS fix
nickdos Aug 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
63 changes: 35 additions & 28 deletions grails-app/views/error.gsp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,39 +2,46 @@
<html>
<head>
<title><g:if env="development">Grails Runtime Exception</g:if><g:else>Error</g:else></title>
<meta name="layout" content="ala"/>
<meta name="layout" content="${grailsApplication.config.getProperty('skin.layout')}"/>
<g:if env="development"><asset:stylesheet src="errors.css" type="text/css"/></g:if>
<style>
ul.errors H1 {
font-size: 18px;
}
</style>
</head>
<body>
<h1>
Application error
</h1>
<g:if env="development">
<ul class="errors">
<g:if test="${Throwable.isInstance(exception)}">
<li><g:renderException exception="${exception}" /></li>
</g:if>
<g:elseif test="${flash.message}">
<li>${alatag.stripApiKey(message: flash.message)}</li>
</g:elseif>
<g:else>
<li>An error has occurred</li>
<li>Exception: ${exception}</li>
<li>Message: ${message}</li>
<li>Path: ${path}</li>
</g:else>
</ul>
</g:if>
<g:else>
<g:if test="${flash.message}">
<div class="${grailsApplication.config.getProperty('skin.fluidLayout')?'container-fluid':'container'}" id="main-content">
<h1>
Application error
</h1>
<hr />
<g:if env="development">
<ul class="errors">
<li>${alatag.stripApiKey(message: flash.message)}</li>
<g:if test="${Throwable.isInstance(exception)}">
<li><g:renderException exception="${exception}" /></li>
</g:if>
<g:elseif test="${flash.message}">
<li>${alatag.stripApiKey(message: flash.message)}</li>
</g:elseif>
<g:else>
<li>An error has occurred</li>
<li>Exception: ${exception}</li>
<li>Message: ${message}</li>
<li>Path: ${path}</li>
</g:else>
</ul>
</g:if>
</g:else>
<ul class="errors">
<li>If this problem persists, please send an email to <a href="mailto:${grailsApplication.config.supportEmail ?: '[email protected]'}?subject=Reporting error on page: ${request.serverName}${request.forwardURI}">${grailsApplication.config.supportEmail ?: '[email protected]'}</a> and include the URL to this page.</li>
</ul>

<g:else>
<g:if test="${flash.message}">
<ul class="errors">
<li>${alatag.stripApiKey(message: flash.message)}</li>
</ul>
</g:if>
</g:else>
<ul class="errors">
<li>If this problem persists, please send an email to <a href="mailto:${grailsApplication.config.supportEmail ?: '[email protected]'}?subject=Reporting error on page: ${request.serverName}${request.forwardURI}">${grailsApplication.config.supportEmail ?: '[email protected]'}</a> and include the URL to this page.</li>
</ul>
</div>
</body>
</html>
14 changes: 9 additions & 5 deletions grails-app/views/notFound.gsp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,14 +2,18 @@
<html>
<head>
<title>Page Not Found</title>
<meta name="layout" content="main">
<meta name="layout" content="${grailsApplication.config.getProperty('skin.layout')}">
<g:if env="development"><asset:stylesheet src="errors.css"/></g:if>
</head>
<body>
<ul class="errors">
<li>Error: Page Not Found (404)</li>
<li>Path: ${request.forwardURI}</li>
</ul>
<div class="${grailsApplication.config.getProperty('skin.fluidLayout')?'container-fluid':'container'}" id="main-content">
<h1>Page Not Found</h1>
<hr />
<ul class="errors">
<li><b>Error:</b> Page Not Found (404)</li>
<li><b>Path:</b> ${request.forwardURI}</li>
</ul>
</div>
<!-- Test test.heading g:message - <g:message code="test.heading" default="not set"/><br>
Test test.heading alatag:message - <alatag:message code="test.heading" default="not set"/><br>
Test test.app.only g:message - <g:message code="test.app.only" default="not set"/><br>
Expand Down