Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a new Windows reinstall method using Ventoy #190

Merged
merged 12 commits into from
Apr 18, 2024
Merged

Add a new Windows reinstall method using Ventoy #190

merged 12 commits into from
Apr 18, 2024

Conversation

kul-sudo
Copy link
Contributor

@kul-sudo kul-sudo commented Apr 12, 2024

Type

  • Rewrite already written documentation.
  • Add/remove new pages.

Questions

Describe your pull request

On Discord I think there's been everything from people typing in oobe\byypassnro to people ignoring this step altogether, so it's probably a good idea to let people avoid that completely.
Another good reason is that it's pretty intuitive: you get the ISO, drag it into the Ventoy USB stick, and it just works. Right now it's assumed the user already has Windows installed somewhere, so this change will allow to in the future explain Linux users how to install Atlas on their machines (that'll probably be my next PR), because Ventoy is supported on Linux.

There's also a tiny change removing a period, because it isn't used in the other tips. Sorry for the double commit, by the way.

@github-actions github-actions bot added the getting-started Issues or PRs related to the 'Getting Started' page label Apr 12, 2024
@kul-sudo kul-sudo changed the title Add a Windows reinstall method using Ventoy Add a new Windows reinstall method using Ventoy Apr 12, 2024
@Ast3risk-ops
Copy link
Contributor

Sir you forgot to add your venv to the gitignore

@kul-sudo
Copy link
Contributor Author

kul-sudo commented Apr 12, 2024

Sir you forgot to add your venv to the gitignore

I did, that's why I had to remove it and commit again. I just don't really do Python, so I missed that. Sorry for that.

@Ast3risk-ops
Copy link
Contributor

Ast3risk-ops commented Apr 12, 2024

well I can't see what you edited as github dies when trying to render your venv, so I'll have to pull this.

Also Rufus can do far more patches than Ventoy ever could. It can create accounts, bypass privacy questions, bypass requirements (ventoy does that already), etc

@kul-sudo
Copy link
Contributor Author

well I can't see what you edited as github dies when trying to render your venv, so I'll have to pull this.

Also Rufus can do far more patches than Ventoy ever coukd

I agree, but that's too many things to explain to a normal user, so Ventoy would be preferred as an alternative installation method.

@Ast3risk-ops
Copy link
Contributor

well I can't see what you edited as github dies when trying to render your venv, so I'll have to pull this.
Also Rufus can do far more patches than Ventoy ever coukd

I agree, but that's too many things to explain to a normal user, so Ventoy would be preferred as an alternative installation method.

I disagree, Rufus is quite simple and intuitive, and it works every time unlike Ventoy.

@kul-sudo
Copy link
Contributor Author

kul-sudo commented Apr 12, 2024

well I can't see what you edited as github dies when trying to render your venv, so I'll have to pull this.
Also Rufus can do far more patches than Ventoy ever coukd

I agree, but that's too many things to explain to a normal user, so Ventoy would be preferred as an alternative installation method.

I disagree, Rufus is quite simple and intuitive, and it works every time unlike Ventoy.

Well, if your secure boot is off and you follow the manual I've composed, it should always work.

@Ast3risk-ops
Copy link
Contributor

Ast3risk-ops commented Apr 12, 2024

Just pulled this, what have you done. We do not go into detail on USB install for a reason, 99% of people do not need to do it.

@kul-sudo
Copy link
Contributor Author

Just pulled this, what have you done.

See the diff.

@Ast3risk-ops
Copy link
Contributor

Just pulled this, what have you done.

See the diff.

github lags when rendering it because you pushed a venv, cloned your fork and am viewing it locally

@Ast3risk-ops
Copy link
Contributor

Ast3risk-ops commented Apr 12, 2024

I would honestly close this, USB install is an afterthought for us anyway, we don't need a method like this (that is also not as well explained and makes the existing info admonition too long)

@kul-sudo
Copy link
Contributor Author

Just pulled this, what have you done.

See the diff.

github lags when rendering it because you pushed a venv, cloned your fork and am viewing it locally

Oh, my bad again. I'll delete the env real quick. Hold on.

@Ast3risk-ops
Copy link
Contributor

Ast3risk-ops commented Apr 12, 2024

Just pulled this, what have you done.

See the diff.

github lags when rendering it because you pushed a venv, cloned your fork and am viewing it locally

Oh, my bad again. I'll delete the env real quick. Hold on.

no dont, you can't do anything about that. Just use pipenv next time, it's already gitignored, and it's way easier to use.

@Ast3risk-ops
Copy link
Contributor

Ast3risk-ops commented Apr 12, 2024

Just pulled this, what have you done. We do not go into detail on USB install for a reason, 99% of people do not need to do it.

and you made the info admonition too long, now people have to scroll past it. Also you put a note admonition on the video when there are written instructions already (i'd just put that in the guide itself)

@kul-sudo
Copy link
Contributor Author

Just pulled this, what have you done. We do not go into detail on USB install for a reason, 99% of people do not need to do it.

and you made the info admonition too long, now people have to scroll past it. Also you put a note admonition on the video when there are written instructions already (i'd just put that in the guide itself)

No, it's actually already removed in the latest commit c878e93 🤔

@kul-sudo
Copy link
Contributor Author

Just pulled this, what have you done. We do not go into detail on USB install for a reason, 99% of people do not need to do it.

and you made the info admonition too long, now people have to scroll past it. Also you put a note admonition on the video when there are written instructions already (i'd just put that in the guide itself)

I'll do it.

@Ast3risk-ops
Copy link
Contributor

Just curious if you've worked with material for mkdocs before.

@kul-sudo
Copy link
Contributor Author

kul-sudo commented Apr 12, 2024

Just curious if you've worked with material for mkdocs before.

No, and I've barely worked with Python expect for my most successful project.

@Ast3risk-ops
Copy link
Contributor

Ast3risk-ops commented Apr 12, 2024

Just curious if you've worked with material for mkdocs before.

No, and I've barely worked with Python expect for my most successful project.

I mean material for mkdocs in general, you don't need to know Python for that. It's quite powerful

@kul-sudo
Copy link
Contributor Author

Just curious if you've worked with material for mkdocs before.

No, and I've barely worked with Python expect for my most successful project.

I mean material for mkdocs in general, you don't need to know Python for that. It's quite powerful

No, I haven't.

@Ast3risk-ops
Copy link
Contributor

Ast3risk-ops commented Apr 12, 2024

Another thing, your ventoy dl link is wrong, it'll pin to a specific version. Use https://github.com/ventoy/Ventoy/releases/latest

@kul-sudo
Copy link
Contributor Author

kul-sudo commented Apr 12, 2024

Another thing, your ventoy dl link is wrong, it'll pin to a specific version. Use https://github.com/ventoy/Ventoy/releases/latest

The thing is that they also store the version in the name of the zip. Moreover, in case they change the UI radically, I don't want the docs to immediately become misleading, so a specific version is safer.

@Ast3risk-ops
Copy link
Contributor

Ast3risk-ops commented Apr 12, 2024

Another thing, your ventoy dl link is wrong, it'll pin to a specific version. Use https://github.com/ventoy/Ventoy/releases/latest

The thing is that they also store the version in the name of the zip. Moreover, in case they change the UI radically, I don't want the docs to immediately become misleading, so a specific version is safer.

Just tell people what to click on the download page. Ventoy's UI will not change, and it's better for them to get updates (also you only link a windows download)

@kul-sudo
Copy link
Contributor Author

Another thing, your ventoy dl link is wrong, it'll pin to a specific version. Use https://github.com/ventoy/Ventoy/releases/latest

The thing is that they also store the version in the name of the zip. Moreover, in case they change the UI radically, I don't want the docs to immediately become misleading, so a specific version is safer.

Just tell people what to click on the download page. Ventoy's UI will not change, and it's better for them to get updates (also you only link a windows download)

All right.

@kul-sudo
Copy link
Contributor Author

kul-sudo commented Apr 12, 2024

Just pulled this, what have you done. We do not go into detail on USB install for a reason, 99% of people do not need to do it.

and you made the info admonition too long, now people have to scroll past it. Also you put a note admonition on the video when there are written instructions already (i'd just put that in the guide itself)

You mean the video? Sure, I can edit it.

@github-actions github-actions bot added the github GitHub repo changes label Apr 12, 2024
@kul-sudo
Copy link
Contributor Author

kul-sudo commented Apr 12, 2024

@Ast3risk-ops Hey, sorry for so many commits, I just couldn't figure something out for some time. Enough about commits, is it better now?

@Ast3risk-ops
Copy link
Contributor

Ast3risk-ops commented Apr 12, 2024

@Ast3risk-ops Hey, sorry for so many commits, I just couldn't figure something out for some time. Enough about commits, is it better now?

Reecommended for simplified setup is not true, we do not recommend Ventoy.

Rufus can also do "simplified setup" but we don't endorse that either.

@kul-sudo
Copy link
Contributor Author

@Ast3risk-ops Hey, sorry for so many commits, I just couldn't figure something out for some time. Enough about commits, is it better now?

Reecommended for simplified setup is not true, we do not recommend Ventoy.

Rufus can also do "simplified setup" but we don't endorse that either.

Removing then. Better now? Also, pay attention to the video I've edited.

@Ast3risk-ops
Copy link
Contributor

Ast3risk-ops commented Apr 12, 2024

@Ast3risk-ops Hey, sorry for so many commits, I just couldn't figure something out for some time. Enough about commits, is it better now?

Reecommended for simplified setup is not true, we do not recommend Ventoy.
Rufus can also do "simplified setup" but we don't endorse that either.

Removing then. Better now? Also, pay attention to the video I've edited.

The edit is kinda bad ngl, but honestly just don't shoehorn that in everywhere, just say in the ventoy instructions (and only there) to skip that, to avoid user confusion.

@kul-sudo
Copy link
Contributor Author

@Ast3risk-ops Hey, sorry for so many commits, I just couldn't figure something out for some time. Enough about commits, is it better now?

Reecommended for simplified setup is not true, we do not recommend Ventoy.
Rufus can also do "simplified setup" but we don't endorse that either.

Removing then. Better now? Also, pay attention to the video I've edited.

The edit is kinda bad ngl, but honestly just don't shoehorn that in everywhere, just say in the ventoy instructions (and only there) to skip that, to avoid user confusion.

Fair enough, I've ditched it 👍

@he3als
Copy link
Contributor

he3als commented Apr 18, 2024

Hi - I'm going to merge this and potentially do some minor changes to formatting and such. If you have any suggestions for my changes, feel free to comment.

This is a very good contribution, so thank you!

@he3als he3als merged commit 1632260 into Atlas-OS:dev Apr 18, 2024
1 check passed
@Ast3risk-ops
Copy link
Contributor

Ast3risk-ops commented Apr 19, 2024

ChatGPT and our MSDL thing helped me make this weird thing to fetch the latest Ventoy release properly:

<script>
    function replace() {
        var styleSheet = document.createElement("style")
        styleSheet.innerText = '.ventoy { display: revert !important }'
        document.head.appendChild(styleSheet)
    }
</script>

<style>
    .ventoy {
        display: none;
    }
</style>

[Download Button](javascript:replace();){ .md-button }


<div id="latest-release-info" class="ventoy"></div>

<script>
   const apiUrl = 'https://api.github.com/repos/ventoy/ventoy/releases/latest';
   fetch(apiUrl)
     .then(response => {
       if (!response.ok) {
         throw new Error('Network response was not ok');
       }
       return response.json();
     })
     .then(data => {
       const latestReleaseInfo = document.getElementById('latest-release-info');
       latestReleaseInfo.innerHTML = `
         <p><a href="${data.assets[3].browser_download_url}" target="_blank" class="md-button" rel="noopener noreferrer">Windows Download</a> <a href="${data.assets[1].browser_download_url}" target="_blank" class="md-button" rel="noopener noreferrer">Linux Download</a></p>
       `;
     })
     .catch(error => {
       console.error('Error fetching data:', error);
     });
</script>

he3als added a commit that referenced this pull request Apr 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
getting-started Issues or PRs related to the 'Getting Started' page github GitHub repo changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants