Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Restrict and better document the calculation and reporting of coverage #95

Merged
merged 9 commits into from
Oct 31, 2023
Merged

Restrict and better document the calculation and reporting of coverage #95

merged 9 commits into from
Oct 31, 2023

Conversation

gkapfham
Copy link
Collaborator

@gkapfham gkapfham commented Oct 26, 2023 •
edited
Loading

This PR modifies the way in which test coverage is calculated and reported.

Here are some details:

  • Only calculate and display code coverage in the GitHub job summary and through the badge when the build runs on Linux
  • Otherwise, only calculate test coverage and show it locally in the build tab. This means that MacOS will have a calculation of test coverage but it will not influence the GitHub Actions job summary or the coverage badge.
  • Make more of the Hypothesis tests tolerant to slow testing processes.
  • Only run the test coverage monitoring process on MacOS right now since slow test coverage monitoring seems to happen more frequently on the Windows operating system.

@gkapfham gkapfham added the infrastructure Docker and CI/CD setup and/or configuration label Oct 26, 2023
@gkapfham gkapfham self-assigned this Oct 26, 2023
@gkapfham gkapfham changed the title WIP: Restrict and better document the calculation and reporting of coverage Restrict and better document the calculation and reporting of coverage Oct 31, 2023
@boulais01 boulais01 added the ready-for-review This pull request is ready for review label Oct 31, 2023
@laurennevill laurennevill merged commit ec287c8 into master Oct 31, 2023
3 checks passed
@laurennevill laurennevill deleted the fix/restrict-coverage-cal branch October 31, 2023 19:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bergasanargya bergasanargya bergasanargya approved these changes

@laurennevill laurennevill laurennevill approved these changes

@simojo simojo simojo approved these changes

@Poiuy7312 Poiuy7312 Awaiting requested review from Poiuy7312

@AidanNeeson AidanNeeson Awaiting requested review from AidanNeeson

@jnormile jnormile Awaiting requested review from jnormile

@tuduun tuduun Awaiting requested review from tuduun

Assignees

@gkapfham gkapfham

Labels
infrastructure Docker and CI/CD setup and/or configuration ready-for-review This pull request is ready for review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@gkapfham @simojo @laurennevill @bergasanargya @boulais01