Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: give analyze the ability to display browsable results #94

Merged
merged 23 commits into from
Nov 6, 2023

Conversation

Poiuy7312
Copy link
Collaborator

@Poiuy7312 Poiuy7312 commented Oct 24, 2023

closes #30

This gives analyze the sub commands --markdown-storage/-r and --display for storing the results in a markdown file and displaying it as a browsable frogmouth display when using --display

Ex

chasten analyze chasten --config $PWD/.chasten/ --debug-level ERROR --debug-dest CONSOLE --search-path . -r . --display

💫 chasten: Analyze the AST of Python Source Code
🔗 GitHub: https://github.com/gkapfham/chasten

✨ Configuration directory: C:\Users\Preston\CMPSC-203\ChastenProject\chasten\.chasten

✨ Validated C:\Users\Preston\CMPSC-203\ChastenProject\chasten\.chasten/config.yml? Yes
✨ Validated C:\Users\Preston\CMPSC-203\ChastenProject\chasten\.chasten/checks.yml? Yes

🐸 Frogmouth Information

 • Venv: C:\Users\Preston\AppData\Local\pypoetry\Cache\virtualenvs\chasten-Ti8Qy4ta-py3.11
 • Program: C:\Users\Preston\AppData\Local\pypoetry\Cache\virtualenvs\chasten-Ti8Qy4ta-py3.11/Scripts/frogmouth.exe

Display example:

image_2023-10-31_152614171

@Poiuy7312 Poiuy7312 added enhancement New feature or request in-progress Work is actively happening on this issue labels Oct 24, 2023
@Poiuy7312 Poiuy7312 self-assigned this Oct 24, 2023
@Poiuy7312 Poiuy7312 changed the title feat: give analyze the ability to store results in a markdown file WIP:feat: give analyze the ability to store results in a markdown file Oct 24, 2023
@Poiuy7312 Poiuy7312 changed the title WIP:feat: give analyze the ability to store results in a markdown file WIP: feat: give analyze the ability to store results in a markdown file Oct 24, 2023
@Poiuy7312 Poiuy7312 requested a review from gkapfham October 24, 2023 18:28
@Poiuy7312
Copy link
Collaborator Author

I'm not sure if this is what was wanted but this is my attempt of giving something that stores the results in a readable form

@Poiuy7312 Poiuy7312 changed the title WIP: feat: give analyze the ability to store results in a markdown file WIP: feat: give analyze the ability to display browsable results Oct 27, 2023
@Poiuy7312 Poiuy7312 changed the title WIP: feat: give analyze the ability to display browsable results feat: give analyze the ability to display browsable results Oct 27, 2023
@Poiuy7312 Poiuy7312 marked this pull request as ready for review October 27, 2023 13:11
@Poiuy7312 Poiuy7312 removed the in-progress Work is actively happening on this issue label Oct 27, 2023
@hayleepierce hayleepierce added the ready-for-review This pull request is ready for review label Oct 30, 2023
Copy link
Collaborator

@tuduun tuduun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @Poiuy7312 , can you please be more descriptive on what changes you have made on this PR? It would be helpful for your team if you could provide a description of what you have made that closes the issue #30 .

@gkapfham
Copy link
Collaborator

Hi @Poiuy7312 can you give an example of what the command-line looks like?
Can you also please give a screenshot that shows what output this produces?

@Poiuy7312 Poiuy7312 requested a review from tuduun October 31, 2023 19:27
@gkapfham
Copy link
Collaborator

gkapfham commented Nov 1, 2023

Thanks @Poiuy7312 this is an awesome feature!

gkapfham
gkapfham previously approved these changes Nov 1, 2023
@gkapfham
Copy link
Collaborator

gkapfham commented Nov 1, 2023

Hello @Poiuy7312 can you confirm that this is only for the analyze sub-command?

@gkapfham
Copy link
Collaborator

gkapfham commented Nov 1, 2023

Also @tuduun, @laurennevill, and/or @jnormile can you review this and provide feedback?

@Poiuy7312
Copy link
Collaborator Author

Poiuy7312 commented Nov 1, 2023 via email

laurennevill
laurennevill previously approved these changes Nov 3, 2023
Copy link
Collaborator

@laurennevill laurennevill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this looks good. Thank you for including a descriptive PR with screenshots and examples. Great work!

@boulais01 boulais01 self-requested a review November 3, 2023 13:13
Copy link
Collaborator

@boulais01 boulais01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One really nitpicky thing - I would say that in main.py, on line 390, I would order the error codes to ignore numerically, so it goes # noq: PLR0912, PLR0913, PLR0915.

@boulais01
Copy link
Collaborator

Something I just noticed as well - make sure you update to master as well

@Poiuy7312 Poiuy7312 requested a review from boulais01 November 3, 2023 13:27
@simojo
Copy link
Collaborator

simojo commented Nov 3, 2023

Just as a note, merging master into your branch still hasn't fixed the downgrading of poetry.lock.

@boulais01
Copy link
Collaborator

@Poiuy7312 I was going to try and resolve the conflicts between the master main.py and the main.py here, but I'm not sure what some of the resolutions should be to maintain functionality. It's only three conflicts, so it shouldn't take long to resolve when you get the chance.

@Poiuy7312 Poiuy7312 dismissed stale reviews from laurennevill and gkapfham via 5a98846 November 4, 2023 15:41
@KevenDuverglas KevenDuverglas self-requested a review November 6, 2023 14:04
@Poiuy7312 Poiuy7312 merged commit 88f36f3 into master Nov 6, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request ready-for-review This pull request is ready for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create a Markdown Report (Or Some Other "Browse-able" Report) for an Analysis
8 participants