-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change --Xpath Versions While Using Chasten Analyze #90
Conversation
@gkapfham, if your work fixes the build issues in this PR, then this would be priority 3 |
This is a great enhancement that will allow for the improved speed of Chasten. And will allow Chasten to have more variety in its |
Can you explain further your feature here @VitalJoseph @Finley8? How can this feature be helpful on the speed running the chasten software? What implementation do you have that could help chasten? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this would be a great addition to chasten.
Hello @VitalJoseph can you please @-mention the specific people who were the main collaborators for this feature in your description of the PR? |
Hello @Finley8 and @VitalJoseph can you please answer the questions that @bergasanargya raised? |
Hello @bergasanargya, thanks for the question. The new implementation will help speed up the chasten analyze command while analyzing multiple programs. The user can also determine whether XPath 1 or XPath 2 analyzes their program quicker by looking at the timer module that is returned after a check. |
When creating a pull request to add a new feature or alter an existing one,
there are some important elements to include to help our team review and process it more efficiently.
Make sure the title is descriptive of what the PR includes. Don't mention issue names/numbers; save that for the description.
List the names of those who contributed to the project.
Vital Joseph, Finley Banas, Keven Duverglas, Jason
https://github.com/AstuteSource/chasten/tree/issue-%2315
The contents of this pull request consists of changes to the command line interface for the analyze function in chasten as well as code that allows the user to specify which xpath parser is ran while parsing the the xpath patterns in the checks.yml file.
The coverage that is maintained/increased has to do with the speed of chasten analyze. Using different versions of xpath we can run the analyze command faster based on what program the user is analyzing.
Mac and Windows
poetry run chasten analyze multicounter --config /Users/finle/chasten/astute_subjects/chasten-configuration -xp 1.0 --search-path /Users/finle/chasten/astute_subjects/subject_forks/multicounter/ --save-directory /Users/finle/chasten/astute_subjects/subject_forks/multicounter --debug-level ERROR --debug-dest SYSLOG --save
poetry run chasten analyze multicounter --config /Users/finle/chasten/astute_subjects/chasten-configuration -xp 2.0 --search-path /Users/finle/chasten/astute_subjects/subject_forks/multicounter/ --save-directory /Users/finle/chasten/astute_subjects/subject_forks/multicounter --debug-level ERROR --debug-dest SYSLOG --save
Mark as a draft until it is ready to begin the reviewing process, then tag our Lead Software Architect, Lauren Nevill,
our Principal Software Engineer, Bergas Batara, and our Founding Engineer, Gregory Kapfhammer
when you mark it as ready for review.