Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: removing covbadge to free the build #87

Merged
merged 2 commits into from
Oct 17, 2023

Conversation

simojo
Copy link
Collaborator

@simojo simojo commented Oct 16, 2023

This PR removes the covbadge build step in order prevent our build from being persistently halted by its faultiness. If merged, we would need to document the fact that this is a temporary change, meaning we would need to reconsider how to fix this issue down the line. For now, considering how 'green' the code base is, we need to prioritize other features.

I will create another PR that reverts this one so that we will have a pending re-implementation of this PR. I will put a note that it needs to be a hold status.

This closes #86, closes #84, and closes #82

@simojo simojo added bug Something isn't working infrastructure Docker and CI/CD setup and/or configuration ready-for-review This pull request is ready for review labels Oct 16, 2023
@simojo simojo self-assigned this Oct 16, 2023
@hayleepierce
Copy link
Collaborator

This will also close issue #14, or at least put it on hold.

Copy link
Collaborator

@jnormile jnormile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the badge, but I agree that at this point it seems to be more trouble than it's worth.

Copy link
Collaborator

@laurennevill laurennevill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree that this will help the project move on a little faster. So long as there is a plan to add this back at a later date, I approve

Copy link
Collaborator

@AidanNeeson AidanNeeson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Get rid of that pesky badge!

@laurennevill laurennevill merged commit d6631d9 into AstuteSource:master Oct 17, 2023
0 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working infrastructure Docker and CI/CD setup and/or configuration ready-for-review This pull request is ready for review
Projects
None yet
5 participants