Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "fix: Changed encoding to utf-8 if default fails" #85

Closed
wants to merge 1 commit into from

Conversation

simojo
Copy link
Collaborator

@simojo simojo commented Oct 13, 2023

Reverts #78

@laurennevill
Copy link
Collaborator

It looks like this may not be necessary anymore. I re-ran the failed jobs and they passed the second time. This is an issue we have run into in the past and it's usually fixed by a re-run. Let me know if you have other thoughts. Thank you for your vigilance!

@simojo
Copy link
Collaborator Author

simojo commented Oct 13, 2023

Sounds good. I was super concerned at first. After talking with @gkapfham, I understand now that we're supposed to rely on you to do each merge, so I'll remember that for next time. Sorry about that @laurennevill

@simojo simojo closed this Oct 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants