Fix: local checkfile used in testing is now general enough #69
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simojo
changed the title
simojo
added
infrastructure
…t from breaking when source of chasten changes
simojo
force-pushed
the
fix/local-checkfile
branch
from
8af0c93 to
d12e0b7
Compare
these checks were hindering our build. They serve no semantic purpose, so it is completely appropriate to remove them.
|
It appears that we're having problems with coverage here. I'll continue to look into this and comment what I find here. I was not expecting this. @laurennevill |
Hopefully fixes the pip install issue on windows
|
Hey @gkapfham, this is priority one for merges |
|
The problem with coverage is still unidentified and unsolved, just letting this thread know. |
fix: update pip command
boulais01
requested review from
tuduun,
AidanNeeson,
bergasanargya and
boulais01
boulais01
approved these changes
Oct 25, 2023
|
@laurennevill @gkapfham , Mordred and I found that the failing checks is a transient issue. I suspect that, because coverage is time consuming, the process is timing out, but this does not appear to be obvious anywhere. Regardless, we have proven that the issue is not consistent, and we both recommend merging this when possible. |
laurennevill
approved these changes
Oct 25, 2023
simojo
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the local checkfile
.chasten/checks.ymlhad checks searching for things like doubly-nestedifstatements found in thechastensource code. Because finding things like this in our repository source code is not set in stone, I have changed this to be general enough to effectively test the functionality without making false assumptions such as the one previously mentioned.Closes #59
NOTE: depends on #68 before merging.
NOTE: @gkapfham is pointing out that #68 has now been merged.