Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: revert master commits again #66

Merged
merged 4 commits into from
Sep 21, 2023
Merged

Fix: revert master commits again #66

merged 4 commits into from
Sep 21, 2023

Conversation

simojo
Copy link
Collaborator

@simojo simojo commented Sep 20, 2023

The other branch intended to do this was cluttered with unintentional commits. This branch reverts unintentional changes made on master.

@simojo simojo added bug Something isn't working in-progress Work is actively happening on this issue labels Sep 20, 2023
jnormile
jnormile approved these changes Sep 21, 2023
View reviewed changes
Copy link
Collaborator

@jnormile jnormile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I appreciate the care and diligence in ensuring that PR's are specific to one task.

Thanks for the clean-up effort!

CalebKendra
CalebKendra approved these changes Sep 21, 2023
View reviewed changes
Copy link
Collaborator

@CalebKendra CalebKendra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you simon your the best

@simojo simojo merged commit 31a42d3 into master Sep 21, 2023
1 check passed
@simojo simojo deleted the fix/revert-master-commits-again branch September 21, 2023 23:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CalebKendra CalebKendra CalebKendra approved these changes

@jnormile jnormile jnormile approved these changes

@Jaclynpqc Jaclynpqc Jaclynpqc approved these changes

@gkapfham gkapfham Awaiting requested review from gkapfham

@AidanNeeson AidanNeeson Awaiting requested review from AidanNeeson

@AlishChhetri AlishChhetri Awaiting requested review from AlishChhetri

@boulais01 boulais01 Awaiting requested review from boulais01

Assignees
No one assigned
Labels
bug Something isn't working in-progress Work is actively happening on this issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@simojo @Jaclynpqc @jnormile @CalebKendra