Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix/revert master commits #62

Closed
wants to merge 41 commits into from
Closed

Fix/revert master commits #62

wants to merge 41 commits into from

Conversation

simojo
Copy link
Collaborator

@simojo simojo commented Sep 19, 2023

No description provided.

Poiuy7312 and others added 30 commits September 15, 2023 10:42
@Poiuy7312
Tried using a os matrix like I saw in gatorgrade
79a1155
@Poiuy7312
Edited workflow
58d4481
@Poiuy7312
Checking Error
11d3530
@Poiuy7312
added bracnh to workflow
d7a3f5a
@Poiuy7312
Removed python 3.10 from ubuntu. Added conditional
8f6e44a
@Poiuy7312
Update poetry.lock
30340ab
@Poiuy7312
Update pyproject.toml
a2f00a4
@Poiuy7312
got rid of special character in main.py
1060f63
@Poiuy7312
Update main.py
dd40f83 
Removed special character to see if its messing with workflow
@Poiuy7312
Update main.py
83105fb
@Poiuy7312
Removed pysqlite3
0bde930
@Poiuy7312
Merge branch 'Work-flow-changes-to-check-more-OS' of github.com:Astut…
6c52e57 
…eSource/chasten into Work-flow-changes-to-check-more-OS
@Poiuy7312
trying to change windows encoding
ebf14f4
@Poiuy7312
Trying a different approach to change encoding
bdf6ba3
@Poiuy7312
Encoding Windows
3bcd345
@Poiuy7312
Removed Special characters
fa53f10
@Poiuy7312
Removed sparkles
d489d23
@Poiuy7312
Removed characters
6691550
@Poiuy7312
Added special character back
b247a41
@Poiuy7312
Reformatted Main.py
0bd58bd
@Poiuy7312
style: changed chasten.emoji in constants.py to *
6a8acd9
@Poiuy7312
style: removed link character from constants.py
bb21175
@Poiuy7312
style: removed ✨ from main.py
2505ec1
@Poiuy7312
style: removed special characters from main.py
18e4190
@simojo
Revert "Add pysqlite3 back to test"
52c8109 
This reverts commit c095ec3.
@simojo
Revert "Version sub-command for Chasten CLI"
633a8f7 
This reverts commit 9e43516.
@simojo
Revert "Modify poetry.lock"
aaa2f9f 
This reverts commit eb58d05.
@simojo
Revert "Remove pysqlite3 package from dependencies"
6ce3ed2 
This reverts commit 9809e56.
@Poiuy7312
style: got rid of checkmarks in util.py
3703e4f
@Poiuy7312
style: removed emoji in main.py
2394e39
@simojo
Copy link
Collaborator Author

simojo commented Sep 19, 2023

This fixes an accidental few commits force pushed to master. Whoops!

jnormile
jnormile previously approved these changes Sep 19, 2023
View reviewed changes
Copy link
Collaborator

@jnormile jnormile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your secret's safe with me.

Jaclynpqc
Jaclynpqc previously approved these changes Sep 19, 2023
View reviewed changes
Copy link
Collaborator

@Jaclynpqc Jaclynpqc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot, @simojo

@gkapfham gkapfham added bug Something isn't working in-progress Work is actively happening on this issue infrastructure Docker and CI/CD setup and/or configuration labels Sep 20, 2023
@Poiuy7312 Poiuy7312 dismissed stale reviews from Jaclynpqc and jnormile via a5cb2b8 September 20, 2023 13:40
@simojo
Copy link
Collaborator Author

simojo commented Sep 20, 2023

Closing because this branch has changes of another feature branch on it. We don't want to mix or PRs.

@simojo simojo closed this Sep 20, 2023
@simojo simojo deleted the fix/revert-master-commits branch September 20, 2023 17:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jnormile jnormile jnormile left review comments

@Jaclynpqc Jaclynpqc Jaclynpqc left review comments

@gkapfham gkapfham Awaiting requested review from gkapfham

@AidanNeeson AidanNeeson Awaiting requested review from AidanNeeson

@AlishChhetri AlishChhetri Awaiting requested review from AlishChhetri

@boulais01 boulais01 Awaiting requested review from boulais01

@CalebKendra CalebKendra Awaiting requested review from CalebKendra

Assignees
No one assigned
Labels
bug Something isn't working in-progress Work is actively happening on this issue infrastructure Docker and CI/CD setup and/or configuration
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@simojo @Jaclynpqc @jnormile @gkapfham @Poiuy7312