Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert for POSIX file paths #60

Merged
merged 6 commits into from
Oct 26, 2023
Merged

Convert for POSIX file paths #60

merged 6 commits into from
Oct 26, 2023

Conversation

Bchass
Copy link
Contributor

@Bchass Bchass commented Sep 19, 2023

Fix for: #58

Looked for other possible conversions in unit tests.

Test results:

platform darwin -- Python 3.11.0, pytest-7.4.0, pluggy-1.2.0
Using --randomly-seed=2186093864
rootdir: /Users/chasserb/Documents/Forks/local/chasten
configfile: pytest.ini
plugins: hypothesis-6.81.1, randomly-3.13.0, dash-2.11.1, cov-4.1.0, clarity-1.0.1, anyio-3.7.1, xdist-3.3.1, pretty-1.2.0
collected 66 items                                                                                                                                  

tests/test_configuration.py ...                                                                                                               [  4%]
tests/test_util.py ...                                                                                                                        [  9%]
tests/test_filesystem.py ................                                                                                                     [ 33%]
tests/test_validate.py ....                                                                                                                   [ 39%]
tests/test_checks.py ...............                                                                                                          [ 62%]
tests/test_main.py .........                                                                                                                  [ 75%]
tests/test_constants.py .....                                                                                                                 [ 83%]
tests/test_debug.py ........                                                                                                                  [ 95%]
tests/test_process.py ...                                                                                                                     [100%]
Results (10.05s):
        66 passed

@gkapfham gkapfham added the test Test case creation and execution label Sep 19, 2023
@jnormile jnormile requested a review from tuduun September 19, 2023 18:44
@jnormile
Copy link
Collaborator

Adding @tuduun to the review given that this will directly impact our testing strategy.

@Bchass
Copy link
Contributor Author

Bchass commented Sep 19, 2023

Hi @Bchass, thanks for your contribution! Some of your fixes in tests/test_main.py appear to still perform file path concatenation by [str] + [Path]. Would you be able to modify this in the following lines?

https://github.com/Bchass/chasten/blob/35fd8f6f3b760e6818107b9665e89008be13d348/tests/test_main.py#L94 https://github.com/Bchass/chasten/blob/35fd8f6f3b760e6818107b9665e89008be13d348/tests/test_main.py#L125 https://github.com/Bchass/chasten/blob/35fd8f6f3b760e6818107b9665e89008be13d348/tests/test_main.py#L147 https://github.com/Bchass/chasten/blob/35fd8f6f3b760e6818107b9665e89008be13d348/tests/test_main.py#L300

Ah, yes! I'll fix those lines later tonight.

@simojo
Copy link
Collaborator

simojo commented Sep 22, 2023

Hi @Bchass everything looks good now, thank you! It seems that somehow, two rogue changes were pushed onto your branch, namely eb3dff6 and 7db0024.

Would you clean your branch's git history and purge these two commits?

@Bchass
Copy link
Contributor Author

Bchass commented Sep 22, 2023

Hi @Bchass everything looks good now, thank you! It seems that somehow, two rogue changes were pushed onto your branch, namely eb3dff6 and 7db0024.

Would you clean your branch's git history and purge these two commits?

Should be all set now

@gkapfham gkapfham merged commit ebf6022 into AstuteSource:master Oct 26, 2023
0 of 3 checks passed
@Poiuy7312 Poiuy7312 linked an issue Nov 3, 2023 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
test Test case creation and execution
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use Path infix operator / in unit tests
4 participants