-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve logging output of function #111
Conversation
@Jaclynpqc Can you please provide the final version of the output and what it looks like? Although I can see the changes in the Files Changed tab, it may be easier for most people to see what it looks like. It may be helpful to display the before and after images of the improved logging system. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello @Jaclynpqc, can you please give examples of the output that this logging output would produce? Can you also confirm that you have tested it and shown that it works for all three of the major operating systems that we support? Also, can you please confirm that it works for both console logging and the syslog server?
This feature works on a linux device. |
This feature works on a Windows device! |
@Jaclynpqc Would you mind posting examples here of the elements @gkapfham requested, so we can close that request change? |
@gkapfham @boulais01 I have tested and confirmed that my implementation works on all three major OS systems, and on both CONSOLE and SYSLOG. This pull request enhances the logging output in the main.py file by strategically placing logging statements in various functions. The improved logging provides detailed information about the execution flow, enabling easier debugging and troubleshooting. I added logging statements relating to debug info, debug destination, file path directory, and current version. For example:
I also added more logging statements at key points of the operation that likely going to cause errors. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello @Jaclynpqc, thanks for this PR, it is helpful and now close to being merged. The main concern that I see right now is that the PR also includes an analysis.md
file. This file was automatically created by the chasten
program because it was running a feature that @Poiuy7312 created. Since this is a derived/generated file we want to make sure that we do not include it inside of our repository. Can you please remove this file and then request another review? Once you have made this change, I think that it should be ready for us to merge to the main trunk! Thanks!
I have made additional changes to this feature. This PR is now ready to merge |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! I have run the tool on my computer, Linux OS, and it does execute the desired result.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work!
Once the changes are resolved, I can merge this |
Oops, this also needs one more Professor/TL review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job on deleting the md file and displaying the output as @gkapfham requested!
This pull request enhances the logging output in the main.py file by strategically placing
logger.debug
statements in various functions. The improved logging provides detailed information about the execution flow, enabling easier debugging and troubleshooting.I added logging statements relating to debug info, debug destination, file path directory, current version using:
For example,
I also add more logging statements at key points of the operation that likely going to cause error.
I attached a screenshot below, in which you could see two server CONSOLE and SYSLOG run at the same time for
chasten analyze
. While CONSOLE returns the checked patterns, SYSLOG returns some logging statement and info that might come in handy when troubleshooting and debugging the code: