Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(pack): make dap work in typescript using vscode-js-debug #163

Closed
wants to merge 1 commit into from
Closed

feat(pack): make dap work in typescript using vscode-js-debug #163

wants to merge 1 commit into from

Conversation

skriems
Copy link

@skriems skriems commented Apr 26, 2023

Hi!

I recently moved from my nvim setup to AstroNvim and really appreciate the work! Awesome suite! I installed the typescript pack and couldn't bring DAP to work properly, basically facing the same issues as in #148.

This PR replicates my working DAP setup with vscode-js-debug in the new lazy format. I hope everything is fine, I only had an issue with the config field for vscode-js-debug: I used config = true but got an error like:

lua module not found for vscode-js-debug. use config func instead...

Didn't really know what to do with that, so I did what the msg told me to do ;)

I added an attach to port config which I usually use while debugging a bunch of docker containers, which expose the inspector thing on different ports. I have not tested the other configs.

Resolves: #148

@mehalter
Copy link
Member

@owittek and @Uzaaft have been working on revamping the typescript stuff and have done some significant restructuring. They just got these changes merged in and this is not out of date and would need rebasing. They are also planning on getting a DAP PR together in the coming week I believe. They should comment on whether or not we should get this rebased and merged in or if we should wait on what they are doing.

@owittek
Copy link
Member

owittek commented Apr 28, 2023

I'll take a look at it tomorrow but from the looks of it I wouldn't rebase it in its current form since the installation of js-debug-adapter should be done with Mason instead of building it. The only other change to the functionality is the addition of ports which might be relevant in getting it to work.

@Uzaaft
Copy link
Member

Uzaaft commented Apr 29, 2023

I think we should wait. We really do not want to be dependent on ts-node unless we absolutely need to.

@mehalter
Copy link
Member

Ok I'm going to go ahead and close this @skriems . I'll be sure to ping you when the new PR is opened to get your feedback though!

@mehalter mehalter closed this Apr 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DAP pack in astrocommunity.pack.typescript is missing typescript dap support
4 participants