feat(typescript): biome pack #1006
Conversation
Review ChecklistDoes this PR follow the [Contribution Guidelines](development guidelines)? Following is a partial checklist: Proper conventional commit scoping:
|
| opts = function(_, opts) | ||
| if not opts.handlers then opts.handlers = {} end | ||
|
|
||
| if not has_biome() then return end |
There was a problem hiding this comment.
Not really happy about this. I tried to use get_clients to just check if biome is attached, but in this case it didn't seem feasible because the lsp is attaching after this config is running.
|
|
||
| -- TODO: prettier should be off for all filetypes that biome supports, | ||
| -- currently this is { "javascript", "javascriptreact", "typescript", "typescriptreact", "json" } | ||
| opts.handlers.prettierd = function() end |
There was a problem hiding this comment.
I don't know much about configuring null-ls, how would you do this?
The reason for wanting to do this is that prettierd will attach to json files even though biome is running and should be the primary formatter, but for markdown it should still be prettier.
|
just found this for picking the formatter dynamically: LazyVim/LazyVim#2116 (comment) will look into it |
|
I think at this point it should just be typescript-biome and not like this. |
|
I.e pack/typescript-biome |
|
updated the structure 👍🏻 |
willparsons
changed the title
There was a problem hiding this comment.
aren't we going to end up having to copy the config around though?
This reverts commit 1e9feeb.
|
Closing this as I don't have time to it anymore. |
Closes #962
TODO
📑 Description
biomepack:pack.typescript-biome.pack.typescript.core.ℹ Additional Information
I pulled out the
coreof the typescript pack so that the eslint+prettier and biome configuration can be separated easily. The default forpack.typescripthasn't changed.