UI - Create new association page #65
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Polymeth
reviewed
Apr 8, 2024
app/src/main/java/com/github/se/assocify/ui/screens/createAsso/CreateAssoScreen.kt
Outdated
Show resolved
Hide resolved
Polymeth
reviewed
Apr 8, 2024
| }, | ||
| title = { Text(text = "Create your association") }) | ||
| }, | ||
| contentWindowInsets = WindowInsets(50.dp, 10.dp, 50.dp, 20.dp)) { innerPadding -> |
There was a problem hiding this comment.
nit: compared to Figma and in my opinion, the left and right padding is a bit big
There was a problem hiding this comment.
For the padding, I discussed with @SidonieBouthors to have the same padding as them. We probably should discuss this with the team to match everyone's padding :)
Polymeth
reviewed
Apr 9, 2024
app/src/main/java/com/github/se/assocify/ui/screens/createAsso/CreateAssoScreen.kt
Outdated
Show resolved
Hide resolved
|
Added a few nit picks but overall good work :). However I would change the PR name before approving imo. |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Connected to user story #32 and issue #22
The UI of the "create a new association" page, where a committee member of an association can register it on the app : with the association's name, logo, and members. Members are users already registered in the app, with their name and picture. They will be assigned a role within the association which will give them different permissions on the app.