Association Utils #60
Conversation
| import com.github.se.assocify.model.entities.User | ||
| import kotlinx.coroutines.flow.MutableStateFlow | ||
|
|
||
| class AssociationUtils( |
There was a problem hiding this comment.
Since it's a view model, wouldn't it be better to name this class AssociationModel or something else containing the word model in it?
There was a problem hiding this comment.
It is not a viewModel, I got confused. I used the functions I wrote for the wrong viewModel to create a class containing utility methods to create/modify/send requests to a certain association
There was a problem hiding this comment.
Okay, so I think you can remove the fact that AssociationUtils inherits from ViewModel()
| import org.mockito.Mockito | ||
| import org.mockito.Mockito.mock | ||
|
|
||
| class AssociationUtilsTest { |
There was a problem hiding this comment.
(if you choose to change the name of your class don't forget to change the name of the test class to be consistent)
| class AssociationUtilsTest { | ||
| private lateinit var db: FirebaseFirestore | ||
| private lateinit var assoApi: AssociationAPI | ||
| private val documentSnapshot = Mockito.mock(DocumentSnapshot::class.java) |
There was a problem hiding this comment.
It seems that the usage of Mockito.mock might be unnecessary here. You could change the mock function calls by removing the Mockito prefix and simply using mock(...) instead.
There was a problem hiding this comment.
You're right gonna fix it asap
| Mockito.`when`(documentSnapshot.toObject(Association::class.java)).thenReturn(oldAssoUpdated) | ||
| Mockito.`when`(documentReference.get()).thenReturn(Tasks.forResult(documentSnapshot)) | ||
|
|
||
| val task = Tasks.forResult(documentSnapshot) |
There was a problem hiding this comment.
This variable is never used you can safely delete it.
|
An Util class to do various operations on an association and to modify the association values on the database.
The class has as objective to solve some problems that will probably come often when dealing with associations, like accepting a new member, asking to enter in the association as a new member or get some elements of the Association.
Here are some functionalities we may want from it, and the advancement of them: