Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

End to end test 2 #299

Merged
merged 17 commits into from
Jun 2, 2024
Merged

End to end test 2 #299

merged 17 commits into from
Jun 2, 2024

Conversation

Mai-LinhC
Copy link
Contributor

No description provided.

@Mai-LinhC Mai-LinhC linked an issue May 14, 2024 that may be closed by this pull request
@Mai-LinhC Mai-LinhC self-assigned this May 14, 2024
@Mai-LinhC
Copy link
Contributor Author

Blocked because I can't add a receipt : can't mock the picture taking part

@SekoiaTree
Copy link
Contributor

(To add to this, there is a bug in MockK that makes it impossible to mock the viewmodel that handles this, making it essentially impossible to do cleanly)

blocked because the receipts are not currently by association, so the test doesn't "work"
@Mai-LinhC Mai-LinhC marked this pull request as ready for review June 2, 2024 12:11
@Mai-LinhC Mai-LinhC requested a review from SekoiaTree June 2, 2024 16:42
Copy link
Contributor

@SekoiaTree SekoiaTree left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks pretty good! Only two minor comments

Copy link
Contributor

@SekoiaTree SekoiaTree left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link

sonarcloud bot commented Jun 2, 2024

@Mai-LinhC Mai-LinhC merged commit c45b55e into main Jun 2, 2024
3 checks passed
@Mai-LinhC Mai-LinhC deleted the mc/224-end-to-end-test-2 branch June 2, 2024 18:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

End-to-end test 2
2 participants