Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding visits and users #27

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Adding visits and users #27

wants to merge 2 commits into from

Conversation

jrhender
Copy link
Collaborator

NOT TESTED YET. Just looking for review on the ideas

@RedTn
Copy link

RedTn commented Sep 29, 2017

Like the idea, was wondering a couple of things. The 'users' class, are you planning to extend this to a client 'user' at some point? If so, we should rethink the schema for that.
Can I also see the updated ER diagram for these new entities, if I understand correctly a restaurant hasmany visits, and visits belongto restaurant and user @kimijin8134 ?

@jrhender
Copy link
Collaborator Author

jrhender commented Oct 5, 2017

Yeah, my intention for the user is for it to represent a 'client user' at some (near) future time. What are you thinking the user schema should look like? It know that it is pretty bare bones at the moment (just FirstName and LastName), but I think it would be pretty easy to add properties in the future if need be
Yeah, a restaurant has many visits, so each visit will have a restaurantID.
And a yea, a visit has many users and users have many visits, so I was gonna a 'join-table' called "UserVisits".
@wfengk and I will update the ER diagram, that's good idea

@RedTn
Copy link

RedTn commented Oct 5, 2017

Your schema sounds good for the relationships.
Sorry when I said client user I really meant API user, since the API will be handling the authentication. If you are going to extend 'user' so people can 'login' with it, then you will need to store a password hash etc., I think ASP.NET has an out of the box class for that. May make more sense to extend a user from that class, then make one yourself

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants