better data sources; fixed measure values; misc #8
Conversation
|
|
||
| // better dev quality, temp solution | ||
| async function getMetrics(): Promise<Metrics> { | ||
| console.log("DEBUG: getMetrics start"); |
There was a problem hiding this comment.
we should consider using logger library (like winston or pino) in order to include debug logs but turn them down in releases
| @@ -1,26 +1,23 @@ | |||
| export type ValueWithMeasureValue = { | |||
There was a problem hiding this comment.
I love that you made this type. This is a bit controversial in typescript, but you could consider replacing type with interface if it's a simple record type (they are generally faster and more composeable), not a blocker and this is just a comment :)
| const res = await fetch("http://testnet-3.arweave.net:1984/metrics"); | ||
| const data = await res.text(); |
There was a problem hiding this comment.
unrelated to the PR, but we are perhaps missing try/catch here?
There was a problem hiding this comment.
For context of this PR no. Because I want that promise should be error, so FE will also receive error, so I can see it in browser console
There was a problem hiding this comment.
you may end up crashing nodejs if it's not caught anywhere, in a single threaded system it would be fatal error. It's not a big deal for now, I mainly thinking it makes sense to give better error messages. Uncaught errors in promises are quite hard to read and understand.
No description provided.