experimental; pub sub metrics; dynamic poll interval #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vird
commented
Nov 17, 2023
| @@ -20,7 +15,7 @@ export default function DataRelatedChart({ | |||
| width: "2%", | |||
| }} | |||
| > | |||
| <TopArrow value={dataPacked} color="#7BF05E" /> | |||
| {typeof dataPacked === "number" && <TopArrow value={dataPacked} color="#7BF05E" />} | |||
There was a problem hiding this comment.
Maybe it's simplier
{dataPacked != null && }
Both checks for null and undefined
There was a problem hiding this comment.
that is indeed a clever trick to catch both, I didn't know it was possible. But since many years, I've avoided the use of == and != in favor of === and !==, I believe eslint will also give an error if you use the the older form, but I guess there are some gems that we lose by always using === / !==. (e.g. > "0" == 0 is true)
|
About extra changes: LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.