Fix: Should not set HDR when it is already enabled #10
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| name: static_analysis | |
| on: | |
| push: | |
| branches: ['**'] | |
| pull_request: | |
| branches: ['**'] | |
| jobs: | |
| CppCheck: | |
| name: CppCheck | |
| timeout-minutes: 30 | |
| runs-on: ubuntu-22.04 | |
| steps: | |
| - uses: actions/checkout@v3 | |
| - name: Install | |
| shell: bash | |
| run: | | |
| sudo apt-get update; | |
| sudo apt-get install -qq cppcheck; | |
| - name: Run | |
| shell: bash | |
| #Selected run options: | |
| # ./xxx : Folders to scan | |
| # --quiet : Don't show current checked configuration in log | |
| # --std=c++11 : Use C++11 standard (default but worth mentioning) | |
| # --xml : Output in XML format | |
| # -j4 : Run parallel jobs for a faster scan. current HW is 2 core (https://docs.github.com/en/actions/using-github-hosted-runners/about-github-hosted-runners) using 4 to future proof | |
| # --enable : Additional check to run. options are [all, warning, style, performance, protability, information, unusedFunction, missingInclude] | |
| # -I : Include directories | |
| # -i : Ignore directories. Ignore third-party libs that we don't want to check | |
| # --suppress : Don't issue errors about files matching the expression (when -i for folders is not enough) | |
| # --force : Check all configurations, takes a very long time (~2 hours) and did not find additional errors. Removed. | |
| # --max-configs=6 : Using less configuration permutations (default is 12) to reduce run time. Detects less errors. Removed. | |
| # -Dxxx : preprocessor configuration to use. Relevant flags taken from build on Ubuntu. | |
| run: > | |
| cppcheck ./src ./include ./common ./tools ./examples ./third-party/realdds ./third-party/rsutils | |
| --quiet --std=c++11 --xml -j4 --enable=warning | |
| -I./src -I./include -I./third-party/rsutils/include -I./common | |
| -i./src/mf -i./src/uvc -i./src/win -i./src/winusb --suppress=*:third-party/json.hpp | |
| -DBUILD_WITH_DDS -DHWM_OVER_XU -DRS2_USE_V4L2_BACKEND -DUNICODE -DUSING_UDEV -DCHECK_FOR_UPDATES -D__linux__ | |
| &> cppcheck_run.log | |
| - name: Diff | |
| id: diff-step | |
| continue-on-error: true | |
| shell: bash | |
| run: | | |
| python3 .github/workflows/cppcheck-parse.py --severity E cppcheck_run.log | sort --key 3 > cppcheck_run.parsed.log | |
| python3 .github/workflows/cppcheck-parse.py --severity E .github/workflows/cppcheck_run.log | sort --key 3 > cppcheck_run.parsed.golden | |
| diff cppcheck_run.parsed.golden cppcheck_run.parsed.log \ | |
| && echo "No diffs found in cppcheck_run.log" | |
| - name: Ensure cppcheck_run.parsed.log was updated | |
| id: diff-parsed-step | |
| continue-on-error: true | |
| shell: bash | |
| run: | | |
| diff cppcheck_run.parsed.golden .github/workflows/cppcheck_run.parsed.log \ | |
| && echo "No diffs found in cppcheck_run.parsed.log" | |
| - name: Upload logs | |
| uses: actions/upload-artifact@v3 | |
| with: | |
| name: cppcheck_log | |
| path: | | |
| cppcheck_run.log | |
| cppcheck_run.parsed.log | |
| - name: Provide correct exit status | |
| shell: bash | |
| run: | | |
| ERROR_COUNT=$(grep cppcheck_run.log -e "severity=\"error\"" -c) || ERROR_COUNT=0 | |
| EXPECTED_ERROR_COUNT=$(grep .github/workflows/cppcheck_run.log -e "severity=\"error\"" -c) || EXPECTED_ERROR_COUNT=0 | |
| if [ $ERROR_COUNT -eq $EXPECTED_ERROR_COUNT ] | |
| then | |
| echo "cppcheck_run succeeded, found" $ERROR_COUNT "errors, as expected" | |
| if [ ${{steps.diff-step.outcome}} == "failure" ] | |
| then | |
| echo "however, the ---> DIFF FAILED <---" | |
| elif [ ${{steps.diff-parsed-step.outcome}} == "failure" ] | |
| then | |
| echo "however, the ---> PARSED log was not UPDATED <---" | |
| else | |
| exit 0 | |
| fi | |
| elif [ $ERROR_COUNT -lt $EXPECTED_ERROR_COUNT ] | |
| then | |
| echo "cppcheck_run ---> SUCCEEDED <--- but found" $ERROR_COUNT "errors when expecting" $EXPECTED_ERROR_COUNT | |
| else | |
| echo "cppcheck_run ---> FAILED <--- with" $ERROR_COUNT "errors; expecting" $EXPECTED_ERROR_COUNT | |
| fi | |
| echo "see the diff step above, or the 'cppcheck_log' artifact (under Summary) for details" | |
| echo "commit all files in the artifact to .github/workflows/ if these are valid results" | |
| exit 1 | |
| #---------------------------------------------------------------------------------------------------# | |
| # We verify the minimal CMake version we support is preserved when building with default CMake flags | |
| minimal_cmake_version: | |
| name: "Minimal CMake version" | |
| timeout-minutes: 30 | |
| runs-on: ubuntu-22.04 | |
| steps: | |
| - name: Checkout | |
| uses: actions/checkout@v3 | |
| - name: "Get current CMake version" | |
| id: cmake_version | |
| run: | | |
| work_dir=$(pwd) | |
| # Go back from RealSense directory to parent directory | |
| cd .. | |
| git clone https://github.com/nlohmann/cmake_min_version.git | |
| cd cmake_min_version | |
| # We clone a specific commit which we tested the process as working | |
| git checkout 687dc56e1cf52c865cebf6ac94ad67906d6e1369 | |
| echo "Install LibRealSense pre-installed packages requirements" | |
| sudo apt-get install libglfw3-dev libgl1-mesa-dev libglu1-mesa-dev at | |
| python3 -mvenv venv | |
| venv/bin/pip3 install -r requirements.txt | |
| venv/bin/python3 cmake_downloader.py --first_minor | |
| output=$(venv/bin/python3 cmake_min_version.py $work_dir) | |
| echo "$output" | |
| # Retrieve CMake minimal version from the last line of the tool output. | |
| current_cmake_version=$(echo ${output: -30} | cut -d'(' -f 2 | head -c -2) | |
| # Saving cmake minimal version string in GitHub output | |
| echo "current_cmake_version=$current_cmake_version" >> $GITHUB_OUTPUT | |
| - name: "Check minimal CMake version" | |
| env: | |
| EXPECTED_CMAKE_VERSION: "VERSION 3.8.0" | |
| CURRENT_CMAKE_VERSION: ${{ steps.cmake_version.outputs.current_cmake_version }} | |
| run: | | |
| regex_pattern="VERSION [0-9]+\.[0-9]+\.[0-9]+" | |
| if ! [[ "$CURRENT_CMAKE_VERSION" =~ $regex_pattern ]]; | |
| then | |
| echo "Error - CMake version $CURRENT_CMAKE_VERSION does not match the pattern VERSION dd.dd.dd" | |
| exit 1 | |
| fi | |
| if [ "$CURRENT_CMAKE_VERSION" == "${EXPECTED_CMAKE_VERSION}" ] || [ "$CURRENT_CMAKE_VERSION" \< "${EXPECTED_CMAKE_VERSION}" ] | |
| then | |
| echo "The test PASSED, current CMake version is $CURRENT_CMAKE_VERSION and it is not higher than ${EXPECTED_CMAKE_VERSION}" | |
| else | |
| echo "Error - The minimal CMake version required for LibRS is ${EXPECTED_CMAKE_VERSION} but on this build the minimal CMake version that works is $CURRENT_CMAKE_VERSION" | |
| exit 1 | |
| fi |