Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pointer network for multi spans #63

Open
wants to merge 66 commits into
base: main
Choose a base branch
from

Conversation

ArneBinder
Copy link
Owner

@ArneBinder ArneBinder commented Feb 7, 2024

TODO

  • use parse() instead of decode() to get the annotations and follow-up candidates
    • SpanEncoderDecoder.parse(): correctly incorporate exclusive_end_offset!
    • tests for all parse() implementations
    • how to handle dummy loop relations? Just not, i.e. head==tail and label=none_label? Edit: just keep it as it is, also see 447e41e
    • use parse() in decode_relations() for decoding
    • use parse() in _prefix_allowed_tokens_fn_with_maximum() to get follow-up candidate indices
    • use parse() in build_constraints()
  • add MultiSpanEncoderDecoder
  • create position_ids from input_ids instead of using decoder_position_id_pattern, see create position_ids based on a mapping (PointerHead) #67
  • test in real setup (sciarg with resolved parts_of_same), see https://github.com/ArneBinder/pie-document-level/pull/204

@ArneBinder ArneBinder added the enhancement New feature or request label Feb 7, 2024
@codecov-commenter
Copy link

codecov-commenter commented Feb 7, 2024

Codecov Report

Attention: Patch coverage is 88.73239% with 48 lines in your changes are missing coverage. Please review.

Project coverage is 95.06%. Comparing base (63e77fe) to head (35d3412).

Files Patch % Lines
...ules/taskmodules/pointer_network_for_end2end_re.py 78.57% 30 Missing ⚠️
...ules/pointer_network/annotation_encoder_decoder.py 94.26% 14 Missing ⚠️
src/pie_modules/taskmodules/common/interfaces.py 90.00% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #63      +/-   ##
==========================================
- Coverage   95.90%   95.06%   -0.84%     
==========================================
  Files          54       54              
  Lines        3927     4232     +305     
==========================================
+ Hits         3766     4023     +257     
- Misses        161      209      +48     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ArneBinder ArneBinder force-pushed the pointer_network_for_multi_spans branch 2 times, most recently from 8ea839f to 8567dc3 Compare February 20, 2024 10:19
@ArneBinder ArneBinder force-pushed the pointer_network_for_multi_spans branch 5 times, most recently from 016114d to 9423941 Compare March 4, 2024 12:11
@ArneBinder ArneBinder force-pushed the pointer_network_for_multi_spans branch 2 times, most recently from aec7135 to 8544f02 Compare March 21, 2024 20:45
…ed, allow all tokens. Maybe the model can recover from this state
@ArneBinder ArneBinder force-pushed the pointer_network_for_multi_spans branch from 8544f02 to 35d3412 Compare March 21, 2024 20:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants