-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pointer network for multi spans #63
Open
ArneBinder
wants to merge
66
commits into
main
Choose a base branch
from
pointer_network_for_multi_spans
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #63 +/- ##
==========================================
- Coverage 95.90% 95.06% -0.84%
==========================================
Files 54 54
Lines 3927 4232 +305
==========================================
+ Hits 3766 4023 +257
- Misses 161 209 +48 ☔ View full report in Codecov by Sentry. |
ArneBinder
force-pushed
the
pointer_network_for_multi_spans
branch
2 times, most recently
from
February 20, 2024 10:19
8ea839f
to
8567dc3
Compare
ArneBinder
force-pushed
the
pointer_network_for_multi_spans
branch
5 times, most recently
from
March 4, 2024 12:11
016114d
to
9423941
Compare
ArneBinder
force-pushed
the
pointer_network_for_multi_spans
branch
2 times, most recently
from
March 21, 2024 20:45
aec7135
to
8544f02
Compare
…coder, i.e. implement parse() for them
…derDecoder and LabeledMultiSpanEncoderDecoder
…e_overlap() and spans_are_nested()
…ed, allow all tokens. Maybe the model can recover from this state
… candidate, we add the eos token
…_up_candidates() fails
…this again in build_constraints()
ArneBinder
force-pushed
the
pointer_network_for_multi_spans
branch
from
March 21, 2024 20:49
8544f02
to
35d3412
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODO
parse()
instead ofdecode()
to get the annotations and follow-up candidatesSpanEncoderDecoder.parse()
: correctly incorporateexclusive_end_offset
!parse()
implementationsJust not, i.e.Edit: just keep it as it is, also see 447e41ehead==tail
andlabel=none_label
?parse()
indecode_relations()
for decodingparse()
in_prefix_allowed_tokens_fn_with_maximum()
to get follow-up candidate indicesparse()
inbuild_constraints()
MultiSpanEncoderDecoder
position_ids
frominput_ids
instead of usingdecoder_position_id_pattern
, see createposition_ids
based on a mapping (PointerHead
) #67parts_of_same
), see https://github.com/ArneBinder/pie-document-level/pull/204