Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PointerNetworkTaskModuleForEnd2EndRE: skip duplicated / conflicting relations during encoding #146

Merged
merged 4 commits into from
Nov 13, 2024

Conversation

ArneBinder
Copy link
Owner

@ArneBinder ArneBinder commented Nov 13, 2024

  • skip relation when another relation with same arguments and same label was already encoded
  • skip whole task encoding if another relation with same arguments and a different label was already encoded

@ArneBinder ArneBinder added the bug Something isn't working label Nov 13, 2024
@codecov-commenter
Copy link

codecov-commenter commented Nov 13, 2024

Codecov Report

Attention: Patch coverage is 85.71429% with 1 line in your changes missing coverage. Please review.

Project coverage is 95.52%. Comparing base (a440655) to head (8d4b1e3).

Files with missing lines Patch % Lines
...ules/taskmodules/pointer_network_for_end2end_re.py 85.71% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #146      +/-   ##
==========================================
+ Coverage   95.45%   95.52%   +0.06%     
==========================================
  Files          61       61              
  Lines        5127     5134       +7     
==========================================
+ Hits         4894     4904      +10     
+ Misses        233      230       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ArneBinder ArneBinder merged commit c481fb4 into main Nov 13, 2024
2 checks passed
@ArneBinder ArneBinder deleted the pointer_re_tm/skip_duplicated_rels branch November 13, 2024 18:14
@ArneBinder ArneBinder changed the title PointerNetworkTaskModuleForEnd2EndRE: skip duplicated / conflicting relations druing encoding PointerNetworkTaskModuleForEnd2EndRE: skip duplicated / conflicting relations during encoding Nov 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants